Closed Bug 1111957 Opened 5 years ago Closed 5 years ago

[e10s] Dragging e10s window between HiDPI and non-HiDPI displays causes text to be scaled incorrectly (again)

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
e10s m5+ ---
firefox36 --- unaffected
firefox37 --- affected

People

(Reporter: cpeterson, Assigned: mconley)

References

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #978913 +++

HiDPI bug 978913 is back:

I have a Retina MacBook Pro with a non-HiDPI external display. When I drag an e10s window from the external display to the MacBook Pro's Retina display, the page text becomes very tiny. If I drag an e10s window from the Retina display to the external display, the page text becomes very large.

I believe this is a regression in Nightly 37 build 2014-12-13:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5288b15d22de&tochange=f14dcd1c8c0b

Unfortunately, mozregression is unable to accurately bisect a narrower regression range.

* Fabrice: could your sync getDPI() changes for FxOS bug 1107259 have affected the desktop browser when e10s is enabled?
Flags: needinfo?(fabrice)
That's very possible, yes. We cache the dpi more aggressively now. We should be able to force a "reset" when moving to another display I guess.
Flags: needinfo?(fabrice)
I *think* this is a matter of clearing out the mDPI and mDefaultScale members in TabChild::RecvUIResolutionChanged. I'll see if that helps.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Clearing mDPI and mDefaultScale seemed to fix the regression. Patch coming up.
Bug 1107259 made TabChild cache the display DPI and default scale more aggressively, and
we need to invalidate those caches when switching displays, otherwise we can get weird
scaling behaviours when switching between displays with different DPIs and scales.
Attachment #8537244 - Flags: review?(fabrice)
FWIW, the regression occurred within the last week or so.
Attachment #8537244 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/769664485cdb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1125325
You need to log in before you can comment on or make changes to this bug.