SidebarTogglePanel() should ignore nodes that aren't panel headers and aren't panel menuitems

RESOLVED FIXED in seamonkey2.34

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Trunk
seamonkey2.34

SeaMonkey Tracking Flags

(seamonkey2.34 fixed)

Details

Attachments

(1 attachment)

Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1229

STR:
Open sidebar.
Click on the [Tabs] button.
Select any menu item that doesn't correspond to a sidebar.
Attachment #8537319 - Flags: review?(neil)
I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this patch but it was apparently already broken before the patch :-(
(In reply to neil@parkwaycc.co.uk from comment #2)
> I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this
> patch but it was apparently already broken before the patch :-(
What should I do here?
(In reply to Philip Chee from comment #3)
> (In reply to comment #2)
> > I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this
> > patch but it was apparently already broken before the patch :-(
> What should I do here?

Review my patch in bug 1117005 ;-)
Attachment #8537319 - Flags: review?(neil) → review+
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/088bd2f60856
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
You need to log in before you can comment on or make changes to this bug.