Closed Bug 1112205 Opened 10 years ago Closed 10 years ago

SidebarTogglePanel() should ignore nodes that aren't panel headers and aren't panel menuitems

Categories

(SeaMonkey :: Sidebar, defect)

Product:
SeaMonkey
Component:
Sidebar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.34 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.34
Tracking Flags:
Tracking Status
seamonkey2.34 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file)

Patch v1.0 Possible fix.
2.25 KB, patch
neil
: review+
Details | Diff | Splinter Review 
Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1229

STR:
Open sidebar.
Click on the [Tabs] button.
Select any menu item that doesn't correspond to a sidebar.

        Attachment #8537319 -
        Flags: review?(neil)

    
    

    
  
I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this patch but it was apparently already broken before the patch :-(

    
    

    
  
(In reply to neil@parkwaycc.co.uk from comment #2)
> I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this
> patch but it was apparently already broken before the patch :-(
What should I do here?

    
    

    
  
(In reply to Philip Chee from comment #3)
> (In reply to comment #2)
> > I wanted to make sure that the "Hide Tab" menuitem wasn't broken by this
> > patch but it was apparently already broken before the patch :-(
> What should I do here?

Review my patch in bug 1117005 ;-)

    
  

        Attachment #8537319 -
        Flags: review?(neil) → review+

    
    

    
  
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/088bd2f60856
Status: ASSIGNED → RESOLVED
Closed: 10 years ago

          status-seamonkey2.34:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: