1112294 - No border around in-content dialogs with high-contrast themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: noBorder.png

When using high-contrast themes or the usage of the page colors is disabled, the in-content dialogs have no border around them and the controls are looking lost and not connected.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: dialogBorder.patch

This patch adds a transparent border around the dialog. With normal themes and with the page colors enabled the border isn't visible. With HC-themes and page colors disabled the transparent border is shown with the foreground color.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: With patch applied

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8537415 [details] [diff] [review]
dialogBorder.patch

Review of attachment 8537415 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.inc.css
@@ +244,5 @@
>  #dialogBox {
>    background-color: #fbfbfb;
>    color: #424e5a;
>    font-size: 14px;
> +  border: 1px solid transparent;

Please add the following comment above this line:
/* `transparent` will use the dialogText color in high-contrast themes and when page colors are disabled */

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Added the comment.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/8da964932383

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8da964932383

Comment 7

[Tim Nguyen :ntim]

You should add background-clip: content-box, so the border isn't visible on the default theme (currently it acts as border: 1px solid #F7F7F7;) on the default theme.

Comment 8

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #7)
> You should add background-clip: content-box, so the border isn't visible on
> the default theme (currently it acts as border: 1px solid #F7F7F7;) on the
> default theme.

meant #FBFBFB, not #F7F7F7. (The color matches the background)

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 37.0a1 (buildID: 20150104030205).