1114344 - Add background-clip: content-box to the #dialogBox on in-content dialogs.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

From bug 1112294 comment 7:
(In reply to Tim Nguyen [:ntim] from comment #7)
> You should add background-clip: content-box, so the border isn't visible on
> the default theme (currently it acts as border: 1px solid #F7F7F7;) on the
> default theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: bug1114344.patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8539810 [details] [diff] [review]
bug1114344.patch

Review of attachment 8539810 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.inc.css
@@ +232,5 @@
>  }
>  
>  #dialogBox {
>    background-color: #fbfbfb;
> +  background-clip: content-box;

With `background-clip:content-box;` the border-radius is hardly visible. It looks like it would have to be increased to 3.5px to match the current style.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: bug1114344.patch

Now with a border-radius of 3px. This makes the radius visible but not to big.

Comment 4

[Tim Nguyen :ntim]

It also makes the box-shadow a bit thicker, maybe 0px 2px 6px 0px rgba(0, 0, 0, 0.3) ?

Comment 5

[Tim Nguyen :ntim]

It also makes the box-shadow a bit thicker, maybe 0 2px 6px 0 rgba(0, 0, 0, 0.3) ?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8540224 [details] [diff] [review]
bug1114344.patch

Review of attachment 8540224 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.inc.css
@@ +243,1 @@
>    box-shadow: 0 2px 4px 0 rgba(0,0,0,0.5);

Looks good, let's go with Tim's recommendation:
box-shadow: 0 2px 6px 0 rgba(0,0,0,0.3);

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

box-shadow changed to Tim's proposal.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/858f0c4f4bdf

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/858f0c4f4bdf

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 37.0a1 (buildID: 20150104030205).