Add background-clip: content-box to the #dialogBox on in-content dialogs.

VERIFIED FIXED in Firefox 37

Status

()

Firefox
Theme
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Firefox 37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
From bug 1112294 comment 7:
(In reply to Tim Nguyen [:ntim] from comment #7)
> You should add background-clip: content-box, so the border isn't visible on
> the default theme (currently it acts as border: 1px solid #F7F7F7;) on the
> default theme.
(Assignee)

Comment 1

3 years ago
Created attachment 8539810 [details] [diff] [review]
bug1114344.patch
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8539810 - Flags: review?(jaws)
Comment on attachment 8539810 [details] [diff] [review]
bug1114344.patch

Review of attachment 8539810 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.inc.css
@@ +232,5 @@
>  }
>  
>  #dialogBox {
>    background-color: #fbfbfb;
> +  background-clip: content-box;

With `background-clip:content-box;` the border-radius is hardly visible. It looks like it would have to be increased to 3.5px to match the current style.
(Assignee)

Comment 3

3 years ago
Created attachment 8540224 [details] [diff] [review]
bug1114344.patch

Now with a border-radius of 3px. This makes the radius visible but not to big.
Attachment #8539810 - Attachment is obsolete: true
Attachment #8539810 - Flags: review?(jaws)
Attachment #8540224 - Flags: review?(jaws)
Comment hidden (obsolete)

Comment 5

3 years ago
It also makes the box-shadow a bit thicker, maybe 0 2px 6px 0 rgba(0, 0, 0, 0.3) ?
Comment on attachment 8540224 [details] [diff] [review]
bug1114344.patch

Review of attachment 8540224 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/incontentprefs/preferences.inc.css
@@ +243,1 @@
>    box-shadow: 0 2px 4px 0 rgba(0,0,0,0.5);

Looks good, let's go with Tim's recommendation:
box-shadow: 0 2px 6px 0 rgba(0,0,0,0.3);
Attachment #8540224 - Flags: review?(jaws) → review+
(Assignee)

Comment 7

3 years ago
Created attachment 8541712 [details] [diff] [review]
Patch for check-in

box-shadow changed to Tim's proposal.
Attachment #8540224 - Attachment is obsolete: true
Attachment #8541712 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/858f0c4f4bdf
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/858f0c4f4bdf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 37.0a1 (buildID: 20150104030205).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.