1112345 - Tab streaming should scroll stream with layers and not offsets

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: layer_scroll.patch

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8537472 [details] [diff] [review]
layer_scroll.patch

Review of attachment 8537472 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think I'm the right person to review this since i have no idea what this patch is trying to accomplish.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8537472 [details] [diff] [review]
layer_scroll.patch

Review of attachment 8537472 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webrtc/MediaEngineTabVideoSource.cpp
@@ +274,1 @@
>                               nsIPresShell::RENDER_DOCUMENT_RELATIVE);

I think this would be clearer if you have something like:

flags = RENDER_DOCUMENT_RELATIVE;
if (mScrollWithPage) {
   flags |= RENDER_IGNORE_VIEWPORT_SCROLLING;
}

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25a7dcfda2b6

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8537472 [details] [diff] [review]
layer_scroll.patch

Approval Request Comment
[Feature/regressing bug #]:Tab Mirroring
[User impact if declined]:Will not be able to uplift additional patches need for Tab Mirroring.
[Describe test coverage new/current, TBPL]: Tab mirroring does not currently have any test coverage that I am aware of.
[Risks and why]: None known
[String/UUID change made/needed]:None known

Please note that this patch actually breaks scrolling in tab mirroring for Fennec and Bug 1115802 will also need to be up lifted in order to fix scrolling in tab mirrors for Fennec.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3956d52ad3f0