Closed
Bug 1112345
Opened 8 years ago
Closed 8 years ago
Tab streaming should scroll stream with layers and not offsets
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(1 file)
3.69 KB,
patch
|
snorp
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8537472 -
Flags: review?(bugmail.mozilla)
Comment 1•8 years ago
|
||
Comment on attachment 8537472 [details] [diff] [review] layer_scroll.patch Review of attachment 8537472 [details] [diff] [review]: ----------------------------------------------------------------- I don't think I'm the right person to review this since i have no idea what this patch is trying to accomplish.
Attachment #8537472 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Updated•8 years ago
|
Attachment #8537472 -
Flags: review?(snorp)
Comment on attachment 8537472 [details] [diff] [review] layer_scroll.patch Review of attachment 8537472 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/webrtc/MediaEngineTabVideoSource.cpp @@ +274,1 @@ > nsIPresShell::RENDER_DOCUMENT_RELATIVE); I think this would be clearer if you have something like: flags = RENDER_DOCUMENT_RELATIVE; if (mScrollWithPage) { flags |= RENDER_IGNORE_VIEWPORT_SCROLLING; }
Attachment #8537472 -
Flags: review?(snorp) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → blassey.bugs
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/25a7dcfda2b6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•8 years ago
|
tracking-fennec: ? → 37+
Assignee | ||
Updated•8 years ago
|
tracking-fennec: 37+ → 36+
Comment 4•8 years ago
|
||
Comment on attachment 8537472 [details] [diff] [review] layer_scroll.patch Approval Request Comment [Feature/regressing bug #]:Tab Mirroring [User impact if declined]:Will not be able to uplift additional patches need for Tab Mirroring. [Describe test coverage new/current, TBPL]: Tab mirroring does not currently have any test coverage that I am aware of. [Risks and why]: None known [String/UUID change made/needed]:None known Please note that this patch actually breaks scrolling in tab mirroring for Fennec and Bug 1115802 will also need to be up lifted in order to fix scrolling in tab mirrors for Fennec.
Attachment #8537472 -
Flags: approval-mozilla-beta?
Updated•8 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•8 years ago
|
Attachment #8537472 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•