1112419 - [Flame][Music] Music is heard through both headphone and speaker when it's started with a timer going off

Status: RESOLVED DUPLICATE of bug 996092

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20141216_MusicThroughSpeakerAndHeadphone.txt

Description:
When a timer goes off and the user starts the music with the alarm still going on, the music is heard through both headphone and speaker.

Pre-requisite: A headphone is plugged in to the device. The device has at least 1 song.

Repro Steps:
1) Update a Flame device to BuildID: 20141216040205.
2) Open Clock app, and set a timer to go off.
3) When the timer goes off, keep the alarm going on.
4) Press Home button.
5) Open Music app, and play a song.
  
Actual:
The music is heard through both headphone and speaker.
  
Expected: 
The music is heard through the headphone only.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141216040205
Gaia: af3d2f89f391c92667e04676fc0ac971e6021bb7
Gecko: a3030140d5df
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: logcat

Comment 1

[Yeojin Chung [:YeojinC]]

adding qawanted for branch check.

Comment 2

[Cody Roesch [:croesch]]

Tested with Shallow Flash on 319mb using Engineering builds.

This bug repro's on Flame KK builds: Flame 2.2 KK, Flame 2.1 KK, Flame 2.0 KK, Flame v188-1 Base

Actual Results: If the timer alarm is going off and you then play music, if you use the song scrubber to fast forward or rewind the song, then the audio for the music will play both through the headphones and through the device speaker.

Repro Rate: 5/5

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141217035735
Gaia: d22dfece04fc00457e8369c660c11f945b088d2f
Gecko: cb8ad2251c09
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141216151310
Gaia: 14315733e2d265a42f9ab02d1aba191789870f70
Gecko: ddecea83ce6e
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141216151108
Gaia: d04710d5d643eeff5a6493aef92a1af672a2769c
Gecko: 4d62570b77e4
Version: 32.0 (2.0) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame v188-1 Base
BuildID: 20141021162107
Gaia: 8c5c956ee6909408e29f375cc7d843a03d92f3d8
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 3

[Cody Roesch [:croesch]]

As far as the repro steps for getting this, I could not just simply play the music when the alarm was going off. I had to slide the song scrubber for the bug to happen.

Prerequisite: Must have headphones plugged in.

1. Set up timer alarm and wait for it to trigger.
2. Play a song in the music app.
3. Slide the song scrubber slider left or right and notice the music now plays out of the speaker as well as the headphones.

Comment 4

[Joshua Mitchell (Inactive)]

NI to Audio owner for blocking decision / assignment

Comment 5

[Edward Chen[:edchen]]

I can heard audio between headphone and speaker. Mark the ticket to blocker 2.2?.
NI developer to trace code to clarify how to work on audio channel.

Comment 6

[Bobby Chien]

As my testing, Music and Alarm will be mixed, and only play either on speaker or on headphone when start playing music. However, if then make music forward and backward, the music and alarm play on both speaker and headphone. This is not a consistent behavior.

-----------

Gaia-Rev        f5e481d4caf9ffa561720a6fc9cf521a28bd8439
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/bb8d6034f5f2
Build-ID        20150111160203
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Comment 7

[Alastor Wu [:alwu]]

This bug can't be reproduced on the gecko version "222539:70de2960aa87".

In this version, when we ignored the alarm then opened the music app to play the song, the music was silent (but it was still playing) and the alarm was heard from both speaker and headphone.

And I checked this behavior on the Android Nexus 5, the result is the same. So maybe it is not a bug?

Comment 8

[Alastor Wu [:alwu]]

I updated my gecko to the latest version, the result is the same.

Gaia-Rev        8a471653ac315dc7467a78e3c907580d92a17f3e
Gecko-Rev       223054:bb8d6034f5f2 
Build-ID        20150112170747
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.alastor.20150109.190131
FW-Date         五  1月  9 19:02:21 CST 2015
Bootloader      L1TC00011880

Ps. I don't know why I can't print the Gecko-Rev by check_version.sh file, so the version number I got is from the HG repository.

Comment 9

[Bobby Chien]

As discussion with Juwei, we need to fix Clock behavior before fix this issue. 

Proposal:
Clock alarm should be dismissed if there is any key press or answer "stop" on the screen. So that we could stop alarm to continue any other operation.

Comment 10

[Alastor Wu [:alwu]]

(In reply to Bobby Chien [:bchien] from comment #9)
> As discussion with Juwei, we need to fix Clock behavior before fix this
> issue. 
> 
> Proposal:
> Clock alarm should be dismissed if there is any key press or answer "stop"
> on the screen. So that we could stop alarm to continue any other operation.

I think that the alarm should not be muted by any other keys press, only when the users really press the stop button or achieve the stop condition.
Because some apps may need users to finish some "specific tasks" (ex. calculating math) before closing the alarm.

Comment 11

[Marcus Cavanaugh [:mcav]]

(In reply to Bobby Chien [:bchien] from comment #9)
> Proposal:
> Clock alarm should be dismissed if there is any key press or answer "stop"
> on the screen. So that we could stop alarm to continue any other operation.

I don't fully understand. Key press in what places, in what apps?

Comment 12

[Bobby Chien]

(In reply to Marcus Cavanaugh [:mcav] (MoCo SF) from comment #11)
> (In reply to Bobby Chien [:bchien] from comment #9)
> > Proposal:
> > Clock alarm should be dismissed if there is any key press or answer "stop"
> > on the screen. So that we could stop alarm to continue any other operation.
> 
> I don't fully understand. Key press in what places, in what apps?

I think we could mute alarm in any following condition (maybe consult UX to final action):
- Answer "stop" to stop alarm
- Home key to stop alarm
- or power key

OR

We could lock alarm screen if user does not answer "stop"

What do you think?

Comment 13

[Juwei Huang[:juwei]]

Hi Marcus,
I think what Bobby said in comment 9 is  when the timer goes off, users can press "home key" to stop the ring.
From ux perspective, I also strongly recommend that pressing any hardware key should stop ringing since users already aware of the timer.

So here's the flow I suggest:
- Timer goes off
- Tap on "volume key" or "home key" or "power key" will dismiss the timer

Any thoughts?

Comment 14

[Bobby Chien]

Hi Marcus, could you help on this? thanks.

Comment 15

[Marcus Cavanaugh [:mcav]]

The bug to dismiss the timer/alarm on hardware key presses is already tracked here: bug 996092.

Comment 16

[StevenLee[:slee]]

As comment 13 and comment 15, the problem will be solved in bug 996092.

Comment 17

[Bobby Chien]

[Blocking Requested - why for this release]: suggest to fix audio mix problem with new audiochannel in v3.0

as comment 16, fix clock behavior in bug 996092.

Comment 18

[Alastor Wu [:alwu]]

Need to verify whether this problem still exists.

Comment 19

[Pi Wei Cheng [:piwei] (inactive)]

This issue is still reproducible on Flame master following steps at comment 0 + comment 2. You have to scrub the music in order for bug to occur; original steps is missing

However this issue behaves differently on Aries. On Aries the Music is not heard via either speaker nor headphone when a timer alarm is active. Music is completely silent when an alarm is going off. So this is a Flame specific issue. I'm not sure if the behavior on Aries is the expected one, but at least it is consistent in the sense that it doesn't change audio output channel to a different one after scrubbing.

Adding Flame to title so people don't mistaken this to be happening on Aries.

Bug occurs on:
Device: Flame 2.5
BuildID: 20150812030210
Gaia: c7875bbc8b32e7b95cc55c9690b03b140905d84d
Gecko: d4f3a8a75577e4af2914a4e899ca2e724f9715c4
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Behaves differently on:
Device: Aries 2.5
BuildID: 20150812135535
Gaia: 6fef72357971934c8774578044ea7a442be3a75d
Gecko: b7efed3a2640fba681d48846c3b2ab80474c6f77
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 20

[Alastor Wu [:alwu]]

According the comment13, this issue should be solved by bug996092.
We should mute the alarm when we press the hardware button.

In addition, the different bug situation described in comment19 is another issue, we should file new bug to handle it. I think that might be related with the bug1188754.