1188754 - Music app doesn't resume after Ringer ends.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Evan Tseng [:evanxd]]

STR:
1. Start Music app to play music in a device.
2. Make a phone call to it.
3. Call screen is showed and Music app stops playing music.

Actual result:
Music app doesn't resume to play music.

Excepted result:
Music app resumes to play music.

Comment 1

[Evan Tseng [:evanxd]]

Hi Alastor,

This might be a gecko issue. After doing STR, the AudioChannelService in gaia does `channel.setMuted(false)` for the content audio channel of Music app. But Music app doesn't resume to play music.

Before doing STR, please do `git apply` these two patch[1][2]. Then you could see the below log.
```
I/GeckoConsole(22554): Content JS LOG: bug-1188754: AppWindow_4_content is playing! 
I/GeckoConsole(22554): Content JS LOG: bug-1188754: AppWindow_4_content is playing!
```

Could you take a look? Thanks.

[1]: https://github.com/evanxd/gaia/commit/4204da4b1cafecaa1ded5343bca9bb6aedc307d0
[2]: https://github.com/evanxd/gaia/commit/c34dd511afb9f44ca1a2d92fb23a990acf243f32

Comment 2

[Alastor Wu [:alwu]]

Attachment: Log

It seems that the audio agent would be stopped when the audio competing happens, so that we can't receive the resume command from the system app.

Comment 3

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1188754 - don't stop agent when the document activity changes

Bug 1188754 - don't stop agent when the document activity changes

The root cause is that we stop the audio agent when the document activity changes when the audio competing starts. (music app is going to the background) After the competing ends, the media element doesn't have the audio agent, so it can't receive the resume command from the system app.

In b2g, we should not change the audio agent at that time, because the system app would be responsible for pausing audio by checking the audio channel type and window activity.

---

Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=253ec74ad5e4

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8649815 [details]
MozReview Request: Bug 1188754 - don't stop agent when the document activity changes

Hi, Baku,
Could you help me review this patch?
The analysis is on the comment3.
Very appreciate :)

Comment 5

[Andrea Marchesini [:baku]]

Ehsan, this code touches one of your last commit about audio policy. Wondering why your code is not enough for b2g.

Comment 6

[(no longer active)]

On desktop and Android, NotifyOwnerDocumentActivityChangedInternal returns true if the owner document is inactive, which lets us detect the case where we are navigating away from the page.  On b2g however, this function may also return true if the media element has been muted by the audio channel agent: <http://hg.mozilla.org/mozilla-central/annotate/29b2df16e961/dom/html/HTMLMediaElement.cpp#l4043>

With that in mind, I think the patch here is wrong, since it causes us to not notify the audio channel agent when the playback stops as you navigate away.  I can think of a better fix, which I will submit in a second.  Alastor, I would appreciate if you can test that please.

Comment 7

[(no longer active)]

Attachment: Do not notify the audio channel agent on Firefox OS when the document activity change callback detects that the element is muted by the audio channel

Comment 8

[Alastor Wu [:alwu]]

Thanks for the patch! 
It works well on the B2g.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b24a94110d0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b24a94110d0