Closed Bug 1112460 Opened 10 years ago Closed 10 years ago

Keyboard build script modification to not preload dictionaries

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S3 (9jan)

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Whiteboard: [p=5])

Attachments

(1 file)

[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master
46 bytes, text/x-github-pull-request
mnjul
: review+
gduan
: review+
mnjul
: feedback+
rudyl
: feedback+
gduan
: feedback+
Details | Review
Let's try to land the build script part of bug 1029951 first. This part consist of introduction of a new GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS build config, and have the build script to load the dictionaries with it, and also generate a dictionary manifest JSON for keyboard app/settings to respond. The config currently pointing to GAIA_KEYBOARD_LAYOUTS to make sure everything is preloaded until the feature is completed.
Depend on bug 1112020 gets landed first -- already rebased.
Depends on: 1112020
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master I plan to add test cases after bug 1111352 is landed, so setting feedback? for now. With this patch we will be generate a JSON for dictionaries and also allow specifying "*" or "noPreloadDictRequired" as layouts. John, I hope the change isn't too much for you to rebase on...
Attachment #8537664 - Flags: feedback?(rlu)
Attachment #8537664 - Flags: feedback?(jlu)
Attachment #8537664 - Flags: feedback?(gduan)
Attachment #8537664 - Flags: feedback?(jlu) → feedback+
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master Looks good to me. Thanks.
Attachment #8537664 - Flags: feedback?(rlu) → feedback+
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master Only nits on github, please check. Thanks.
Attachment #8537664 - Flags: feedback?(gduan) → feedback+
Need another rebase once bug 1111352 landed.
Depends on: 1111352
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master The patch is now updated with tests in place, and all feedback addressed. Thanks. The added build tests takes 26sec on my machine. I don't know if that could increase Gb timeout. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c2638c25ae8a
Attachment #8537664 - Flags: review?(rlu)
Attachment #8537664 - Flags: review?(jlu)
Attachment #8537664 - Flags: review?(gduan)
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master The test failed on CI ... even though it works on my machine :-/ Will look deeper.
Attachment #8537664 - Flags: review?(rlu)
Attachment #8537664 - Flags: review?(jlu)
Attachment #8537664 - Flags: review?(gduan)
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master It turned out to be a sorting issue. This one should pass.
Attachment #8537664 - Flags: review?(rlu)
Attachment #8537664 - Flags: review?(jlu)
Attachment #8537664 - Flags: review?(gduan)
Looks like the Gb is still failing :(
Codes look good, please check the GitHub comments. Will r+ once the Gb issue is resolved ;)
Attachment #8537664 - Flags: review?(jlu) → review+
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master Rudy is PTO today.
Attachment #8537664 - Flags: review?(rlu)
Comment on attachment 8537664 [details] [review] [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master looks good to me, r=gduan
Attachment #8537664 - Flags: review?(gduan) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8a471653ac315dc7467a78e3c907580d92a17f3e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [p=5]
Target Milestone: --- → 2.2 S3 (9jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: