1112460 - Keyboard build script modification to not preload dictionaries

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let's try to land the build script part of bug 1029951 first.

This part consist of introduction of a new GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS build config, and have the build script to load the dictionaries with it, and also generate a dictionary manifest JSON for keyboard app/settings to respond.

The config currently pointing to GAIA_KEYBOARD_LAYOUTS to make sure everything is preloaded until the feature is completed.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Depend on bug 1112020 gets landed first -- already rebased.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

I plan to add test cases after bug 1111352 is landed, so setting feedback? for now. With this patch we will be generate a JSON for dictionaries and also allow specifying "*" or "noPreloadDictRequired" as layouts.

John, I hope the change isn't too much for you to rebase on...

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

Looks good to me.
Thanks.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

Only nits on github, please check. Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Need another rebase once bug 1111352 landed.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

The patch is now updated with tests in place, and all feedback addressed. Thanks.

The added build tests takes 26sec on my machine. I don't know if that could increase Gb timeout.

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c2638c25ae8a

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

The test failed on CI ... even though it works on my machine :-/

Will look deeper.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

It turned out to be a sorting issue. This one should pass.

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

Looks like the Gb is still failing :(

Comment 11

[John Lu [:mnjul][Please NI or I'll miss]]

Codes look good, please check the GitHub comments. Will r+ once the Gb issue is resolved ;)

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

Rudy is PTO today.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8537664 [details] [review]
[PullReq] timdream:keyboard-dyn-build to mozilla-b2g:master

looks good to me, r=gduan

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/8a471653ac315dc7467a78e3c907580d92a17f3e