Closed Bug 1112554 Opened 11 years ago Closed 11 years ago

Set the default thServiceDomain to the current hostname

Categories

(Tree Management :: Treeherder, defect, P1)

Product:
Tree Management
Component:
Treeherder
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mdoglio, Assigned: mdoglio)

References

Details

Attachments

(1 file)

PR 307 on Treeherder UI
49 bytes, text/x-github-pull-request
Details | Review
That would simplify the deployment process and make it less error-prone.
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #8537817 - Flags: review?(emorley)
Comment on attachment 8537817 [details] [review] PR 307 on Treeherder UI This breaks using web-server.js, which is something that may be inevitable (given bug 1060313 comment 1), but if this is a route we wish to go down, then we should remove web-server.js from the tree and adjust the documentation as part of this PR too, IMO :-)
Attachment #8537817 - Flags: review?(emorley)
See Also: → 1071541
I think the use of web-server.js can still be useful even if it's not enabled by default. I already had a look at the docs and they are pretty generic, do you think I should make the new default more explicit there?
Yeah true - let's leave web-server.js in place, but just update the docs to say you need to change the value of thServiceDomain back to prod (we could have that line in the example config but commented out to make things quicker).
Ok, I'll update the patch
Attachment #8537817 - Flags: review?(emorley)
Attachment #8537817 - Flags: review?(emorley)
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/7b011cf58b509dee3da9ecb4cb967266d6bf1e1c Bug 1112554 - set thServiceDomain to current host https://github.com/mozilla/treeherder-ui/commit/a3029cba177d93355b4139101303187dd9ce136e Merge pull request #307 from mozilla/bug-1112554-th-service-domain Bug 1112554 - set thServiceDomain to current host
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/18bf5bf5fdf0ee98612bff3105727a8cd0876847 Bug 1112554 - set thServiceDomain to current host https://github.com/mozilla/treeherder/commit/ead8bc1339bdb25002b9f10dedff29af03613e3c Merge pull request #307 from mozilla/bug-1112554-th-service-domain Bug 1112554 - set thServiceDomain to current host
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: