Closed Bug 1112565 Opened 5 years ago Closed 5 years ago

UiTour: Non-sticky behavior of Hello panel when opened using "Get Started"

Categories

(Firefox :: Tours, defect)

37 Branch
defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: agibson, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

Issue: 

When opening the Hello FTE via the "Get Started" button, the panel is already open when the page FTE loads. This means the panel does not exhibit the usual "sticky" behavior that we have when calling showMenu('loop') directly (the page is already calling this this on load, but I'm assuming it just returns because the menu is already open, which makes sense).

This means that when the FTE starts, clicking anywhere on the web page will close the menu and door-hanger. I think there's a chance some people might do this accidently, and not read the door-hanger text in time.

Perhaps it makes sense to close the panel when someone clicks "Get Started"? This already seems to be the behavior when clicking the "Tour" link in the gears menu.

It's also worth noting that we have the same issue when the user has a conversation waiting, and they click the hello icon which re-opens the tab. I'm not sure what we can do in this case? I could hide and then reshow the menu on page load, but this might appear a bit weird.
(In reply to Alex Gibson [:agibson] from comment #0)
> It's also worth noting that we have the same issue when the user has a
> conversation waiting, and they click the hello icon which re-opens the tab.
> I'm not sure what we can do in this case? I could hide and then reshow the
> menu on page load, but this might appear a bit weird.

I resolved this part in bug 1080953. I'll solve the initial tour opening here.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 37.2
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
/r/1575 - Bug 1112565 - Close the Loop panel when opening the getting started tour. r=dolske

Pull down this commit:

hg pull review -r 7cca556fc765a08e52902181ef807a041f6567a0
Attachment #8538256 - Flags: review?(dolske) → review+
Comment on attachment 8538256 [details]
MozReview Request: bz://1112565/MattN

(rs=me based on the similar patch in bug 1112565)

[Triage Comment]

Needed for Fx35 Hello tour. No unusual risk.
Attachment #8538256 - Flags: approval-mozilla-beta+
Attachment #8538256 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/207df86f28e0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8538256 - Attachment is obsolete: true
Attachment #8618934 - Flags: review+
You need to log in before you can comment on or make changes to this bug.