1112594 - Sometimes the net-error page is cut off at the bottom

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Chris Lord [:cwiiis]]

Sometimes the net-error page is cut off at the bottom - this is easily reproduced if you turn off network and try to load the Facebook application.

This is because the switch to the net-error page doesn't fire a locationchange signal and so whatever state there was before the error is retained.

I've had a fix for this in my local tree for ages, so assigning.

Comment 1

[Chris Lord [:cwiiis]]

Here's the fix, just need to write a unit test: https://github.com/Cwiiis/gaia/tree/bug1112594-fix-cut-off-neterror

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Fix neterror page sometimes being cut off

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8537935 [details] [review]
Fix neterror page sometimes being cut off

r=me

Comment 4

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/a1c514b158cc25a1ffa2fa78177b78277243b068