1112596 - The loading indicator doesn't appear when launching Facebook

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Chris Lord [:cwiiis]]

I assume this happens for other apps that use the browser chrome too.

The issue is that the browser chrome is loaded asynchronously and it's possible for the loadstart signal to be missed (because it's the browser chrome that listens to it).

Marking this as depending on bug 1112594 as that bug deals with a similar issue and I don't want to do conflict resolution :)

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix loadstart handling before chrome loads

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8545982 [details] [review]
Fix loadstart handling before chrome loads

LGTM but need a test, thanks!

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8545982 [details] [review]
Fix loadstart handling before chrome loads

Test added :)

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8545982 [details] [review]
Fix loadstart handling before chrome loads

Better having the two commits rebased into one commit.

Comment 5

[Chris Lord [:cwiiis]]

Fixed linter error, rebased into one commit, merged: https://github.com/mozilla-b2g/gaia/commit/925a14c9e18fc0cfde2f35a9fea0f5452e202ccb

Apologies if there are test failures - tests ran fine locally, for some reason they aren't being triggered on the pull request...

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8545982 [details] [review]
Fix loadstart handling before chrome loads

Narrowly missed branch date, requesting uplift.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Apps that use browser chrome (such as Facebook) can be loading data without appearing like they're loading data.
[Testing completed]: Locally, with automated testing and been on master for a week.
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: None

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

v2.2: https://github.com/mozilla-b2g/gaia/commit/60b4c8a0038d7910ac68f0baf539c54b634f7269

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: The loading indicator appears when launching Facebook app.
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150130002501
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: 63b63054948d
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150130010210
Gaia: 8238eeacc7030b2cdbf7ab4eba2f36779b702599
Gecko: 29b05d283b00
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0