1112609 - Bisect Chunk does not run.

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Kaustabh Datta Choudhury]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141127111021

Steps to reproduce:

Running :  ./mach mochitest-plain --bisect-chunk testing/mochitest



Actual results:

Runing mochitest with --biseckunk  generated the following error :

 global name 'log' is not defined

Comment 1

[Kaustabh Datta Choudhury]

Related : https://bugzilla.mozilla.org/show_bug.cgi?id=1060439

Comment 2

[Kaustabh Datta Choudhury]

Attachment: bisect.patch

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8537864 [details] [diff] [review]
bisect.patch

Review of attachment 8537864 [details] [diff] [review]:
-----------------------------------------------------------------

This should make your patch a one line change.  In addition please add a commit message, it is usually  the bug and title or subject of the patch, something like this:
Bug 1112609 - Bisect Chunk does not run. r=jmaher

you can do that with 'hg qref -e', then edit the message.

::: testing/mochitest/runtests.py
@@ +1697,5 @@
>        if options.bisectChunk:
>          testsToRun = bisect.pre_test(options, testsToRun, status)
>          # To inform that we are in the process of bisection, and to look for bleedthrough
>          if options.bisectChunk != "default" and not bisection_log:
> +            logging.info("TEST-UNEXPECTED-FAIL | Bisection | Please ignore repeats and look for 'Bleedthrough' (if any) at the end of the failure list")

we should be able to use:
self.log.info(...)

Comment 4

[Kaustabh Datta Choudhury]

Attachment: bisection.patch

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this looks to be requiring your first patch.  If you could:
hg qpop -a
hg pull -u (this rebases your repository)
hg qnew bisect.patch
<make your changes>
hg qref -e ...

submit new patch!

Comment 6

[Kaustabh Datta Choudhury]

Attachment: bisect.patch

Comment 7

[Kaustabh Datta Choudhury]

Attachment: bisect.patch

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

https://tbpl.mozilla.org/?tree=Try&rev=8c08650edae7

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8538643 [details] [diff] [review]
bisect.patch

Review of attachment 8538643 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, it looks good on try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c08650edae7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8537864 [details] [diff] [review]
bisect.patch

In the future, please mark patches obsolete when attaching updated ones.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5504551301

Comment 12

[Vaibhav (:vaibhav1994)]

Kaustabh, thanks for fixing this up! 
I have pushed to try to check if bisect-chunk works now: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=897ad2bbd2dd

Comment 13

[Kaustabh Datta Choudhury]

Thank you. 
As of now I am trying to understand my way around mochitest.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f5504551301