1112700 - Browser Toolbox Inspector crash: Assertion failure: aPropID != eCSSPropertyExtra_variable

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:
1. Start a debug build of latest from fx-team[1]
2. Open the Browser Toolbox
3. Select the inspector tab

[1]: http://hg.mozilla.org/integration/fx-team/rev/66cc38d90f25

Assertion failure: aPropID != eCSSPropertyExtra_variable, at ../../../layout/style/nsCSSParser.cpp:9521
#01: (anonymous namespace)::CSSParserImpl::ParseProperty(nsCSSProperty)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x37144cb]
#02: (anonymous namespace)::CSSParserImpl::IsValueValidForProperty(nsCSSProperty, nsAString_internal const&)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x36d9b56]
#03: nsCSSParser::IsValueValidForProperty(nsCSSProperty, nsAString_internal const&)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x36d9a11]
#04: inDOMUtils::CssPropertyIsValid(nsAString_internal const&, nsAString_internal const&, bool*)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3c26344]
#05: NS_InvokeByIndex[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x19f142]
#06: CallMethodHelper::Invoke()[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf43038]
#07: CallMethodHelper::Call()[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf33107]
#08: XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf119c4]
#09: XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xf13b98]
#10: js::CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5c108f4]
#11: js::Invoke(JSContext*, JS::CallArgs, js::MaybeConstruct)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5b905ad]
#12: Interpret(JSContext*, js::RunState&)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5bb1603]
#13: js::RunScript(JSContext*, js::RunState&)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5ba4cfa]
#14: js::Invoke(JSContext*, JS::CallArgs, js::MaybeConstruct)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5b906f1]
#15: js::InvokeConstructor(JSContext*, JS::CallArgs)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5bbcd15]
#16: js::InvokeConstructor(JSContext*, JS::Value, unsigned int, JS::Value const*, JS::MutableHandle<JS::Value>)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5bbcfc1]
#17: js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>)[/Users/jryans/projects/mozilla/gecko-dev-2/obj-firefox-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x55cfd0b]

Comment 1

[Daniel Holbert [:dholbert]]

Seems like this is in heycam's wheelhouse, given that it's CSS-variable code.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Seems like this is in heycam's wheelhouse, given that it's CSS-variable code.

His wheelhouse, my code. In fact, this is best fixed from inDOMUtils.cpp... I am onto it.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: 1112700-fix-assertion-aPropID-not-eCSSPropertyExtra_variable.patch

CSS vars accept any value so returning true from DOMUtils.CssPropertyIsValid() is the obvious fix... this codepath must never have worked.

r=me in the interests of getting the browser toolbox up and running again.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8538387 [details] [diff] [review]
1112700-fix-assertion-aPropID-not-eCSSPropertyExtra_variable.patch

https://hg.mozilla.org/integration/fx-team/rev/a24e89b3b206

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a24e89b3b206