Control runtime auto-connect

RESOLVED FIXED in Firefox 37

Status

()

Firefox
Developer Tools: WebIDE
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

Trunk
Firefox 37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Offer a pref and UI option for runtime auto-connect.
(Assignee)

Updated

3 years ago
Depends on: 1112847
(Assignee)

Comment 2

3 years ago
Created attachment 8538160 [details] [diff] [review]
0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8538160 - Flags: review?(poirot.alex)
Comment on attachment 8538160 [details] [diff] [review]
0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch

Review of attachment 8538160 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #8538160 - Flags: review?(poirot.alex) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Hi,

this patch didn't apply cleanly:

applying 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
patching file browser/devtools/webide/content/webide.js
Hunk #1 FAILED at 395
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/webide/content/webide.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch

could you take a look, thanks!
Flags: needinfo?(jryans)
Keywords: checkin-needed
(Assignee)

Comment 5

3 years ago
It should work if you apply bug 1112847 that it depends on (also marked checkin-needed) first.
Flags: needinfo?(jryans) → needinfo?(cbook)
(In reply to J. Ryan Stinnett [:jryans] from comment #5)
> It should work if you apply bug 1112847 that it depends on (also marked
> checkin-needed) first.

yeah that worked, thanks!
Flags: needinfo?(cbook)
https://hg.mozilla.org/mozilla-central/rev/ad9c605a9287
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.