1112836 - Control runtime auto-connect

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Offer a pref and UI option for runtime auto-connect.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95ca89c377f3

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8538160 [details] [diff] [review]
0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch

Review of attachment 8538160 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 4

[Carsten Book [:Tomcat]]

Hi,

this patch didn't apply cleanly:

applying 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
patching file browser/devtools/webide/content/webide.js
Hunk #1 FAILED at 395
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/webide/content/webide.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch

could you take a look, thanks!

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It should work if you apply bug 1112847 that it depends on (also marked checkin-needed) first.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ad9c605a9287

Comment 7

[Carsten Book [:Tomcat]]

(In reply to J. Ryan Stinnett [:jryans] from comment #5)
> It should work if you apply bug 1112847 that it depends on (also marked
> checkin-needed) first.

yeah that worked, thanks!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad9c605a9287