Closed
Bug 1112836
Opened 10 years ago
Closed 10 years ago
Control runtime auto-connect
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file)
|
5.50 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Offer a pref and UI option for runtime auto-connect.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8538160 [details] [diff] [review]
0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
Review of attachment 8538160 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #8538160 -
Flags: review?(poirot.alex) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Hi,
this patch didn't apply cleanly:
applying 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
patching file browser/devtools/webide/content/webide.js
Hunk #1 FAILED at 395
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/webide/content/webide.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0002-Bug-1112836-Control-runtime-auto-connect-in-UI.-r-oc.patch
could you take a look, thanks!
Flags: needinfo?(jryans)
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•10 years ago
|
||
It should work if you apply bug 1112847 that it depends on (also marked checkin-needed) first.
Flags: needinfo?(jryans) → needinfo?(cbook)
|
|
||
Comment 6•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 7•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #5)
> It should work if you apply bug 1112847 that it depends on (also marked
> checkin-needed) first.
yeah that worked, thanks!
Flags: needinfo?(cbook)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•