1112847 - Only connect once with auto-connect

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Auto-connect today can trigger multiple connection attempts, as it gets triggered for every new runtime in the runtime list.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae3c104876cd

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1112847/jryans

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/1551 - Bug 1112847 - Only connect once with auto-connect. r=ochameau

Pull down this commit:

hg pull review -r 20a7244bf2d3182f10914d48b2e8a42a4ce4c93c

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/1551 - Bug 1112847 - Only connect once with auto-connect. r=ochameau
/r/1557 - Bug 1112836 - Control runtime auto-connect in UI. r=ochameau

Pull down these commits:

hg pull review -r 4e9bc531a05852c335d83b773c81bc4d3369d99d

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1112847-Only-connect-once-with-auto-connect.-r-o.patch

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8538159 [details] [diff] [review]
0001-Bug-1112847-Only-connect-once-with-auto-connect.-r-o.patch

Review of attachment 8538159 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but I miss the precise connect scenario you are trying to avoid?

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #6)
> Comment on attachment 8538159 [details] [diff] [review]
> 0001-Bug-1112847-Only-connect-once-with-auto-connect.-r-o.patch
> 
> Review of attachment 8538159 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good but I miss the precise connect scenario you are trying to avoid?

It's related to the auth I am building for WiFi in bug 1103120, sorry for not being more clear.

Prior to this patch, we'd call |connectToRuntime| as each runtime item is added.  So once you have one runtime that matches what was saved, we keep calling |connectToRuntime| for each runtime added.  So, you can get N calls to |connectToRuntime| when only one is needed if you have N available runtimes.

For the moment, it's probably not noticeable that we call |connectToRuntime| N times, as we'll just eventually use the last one.  But for WiFi authentication, I need to display a dialog in WebIDE when connecting, so N connections means N dialogs stacking on top of each other crazily.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/4b6433d98835

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4b6433d98835