1113247 - UiTour: Hello FTE incoming conversation / tab issues

Status: RESOLVED INVALID

(Firefox :: Tours, defect)

Description

[Alex Gibson [:agibson]]

There are some remaining issues that seem to need attention after Bug 1080953 landed.

The main issue seems to be when the incoming call is received. The hello panel does not open when the blue icon is clicked, and when it does it seems to fire repeated "Loop:IncomingConversation" events which interfere with the page.

For example:

- I leave the tab open after sharing the link, but close the conversation view:

When the other person connects, the hello icon turns blue as expected. I go to click it, but the hello panel doesn't open. At this point I get sent *lots* of "Loop:IncomingConversation" events to the point where it starts to slow down the browser.

Please note this also seems to effect all scenarios where the conversation connects. The next time the hello icon is clicked, I get hundreds of events one after the other?

Not quite sure what's going on...

Comment 1

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Adding this as a blocker to UITour for Hello instead.

Comment 2

[Matthew N. [:MattN]]

OK, I think I know what's going on:

The page is doing setConfiguration("Loop:ResumeTourOnFirstJoin", false); even though the Loop code is doing this already. The problem is that I made setConfiguration("Loop:ResumeTourOnFirstJoin", …) always set the pref to True since I didn't think the page would ever need to set it to false[1] and I didn't want to have to deal with sanitizing the input for now. Removing setConfiguration("Loop:ResumeTourOnFirstJoin", false);  fixes the problem.

I don't think we need a product change for now.

[1] https://mxr.mozilla.org/mozilla-central/source/browser/modules/UITour.jsm?rev=8a4a29b0c603#1494

Comment 3

[Alex Gibson [:agibson]]

(In reply to Matthew N. [:MattN] from comment #2)
> OK, I think I know what's going on:
> 
> The page is doing setConfiguration("Loop:ResumeTourOnFirstJoin", false);
> even though the Loop code is doing this already. The problem is that I made
> setConfiguration("Loop:ResumeTourOnFirstJoin", …) always set the pref to
> True since I didn't think the page would ever need to set it to false[1] and
> I didn't want to have to deal with sanitizing the input for now. Removing
> setConfiguration("Loop:ResumeTourOnFirstJoin", false);  fixes the problem.
> 
> I don't think we need a product change for now.
> 
> [1]
> https://mxr.mozilla.org/mozilla-central/source/browser/modules/UITour.
> jsm?rev=8a4a29b0c603#1494

Ah i see! thanks for the clarification Matt,

I've just tested my local copy with the changes above and it seems to be behaving.

We can keep this bug closed :)

If I notice anything else I don't quite follow, I'll ping you / open a new bug.

Thanks again