Closed
Bug 1113631
Opened 10 years ago
Closed 10 years ago
Remove ServiceWorker registration when installation failure occurs.
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.35 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•10 years ago
|
Blocks: ServiceWorkers-v1
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8539241 -
Flags: review?(amarchesini)
|
||
Comment 2•10 years ago
|
||
Attachment #8539409 -
Flags: review?(hurley)
|
|
||
Updated•10 years ago
|
Assignee: nsm.nikhil → mcmanus
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8539409 [details] [diff] [review]
broken h2 dependency id
landed this in wrong bug. sorry.
Attachment #8539409 -
Attachment is obsolete: true
Attachment #8539409 -
Flags: review?(hurley)
|
|
||
Updated•10 years ago
|
Assignee: mcmanus → nsm.nikhil
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8539241 [details] [diff] [review]
Remove registration when installation failure occurs.
Review of attachment 8539241 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/workers/ServiceWorkerManager.cpp
@@ +676,5 @@
> + }
> +
> + void
> + MaybeRemoveRegistration()
> + {
MOZ_ASSERT(mRegistration)
Attachment #8539241 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/e9d37cd95335 for asan mochitest-4 bustage:
https://treeherder.mozilla.org/logviewer.html#?job_id=5846451&repo=mozilla-inbound
Flags: needinfo?(nsm.nikhil)
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(nsm.nikhil)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•