Closed Bug 1113631 Opened 7 years ago Closed 7 years ago

Remove ServiceWorker registration when installation failure occurs.

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch broken h2 dependency id (obsolete) — Splinter Review
Attachment #8539409 - Flags: review?(hurley)
Assignee: nsm.nikhil → mcmanus
Comment on attachment 8539409 [details] [diff] [review]
broken h2 dependency id

landed this in wrong bug. sorry.
Attachment #8539409 - Attachment is obsolete: true
Attachment #8539409 - Flags: review?(hurley)
Assignee: mcmanus → nsm.nikhil
Comment on attachment 8539241 [details] [diff] [review]
Remove registration when installation failure occurs.

Review of attachment 8539241 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +676,5 @@
> +  }
> +
> +  void
> +  MaybeRemoveRegistration()
> +  {

MOZ_ASSERT(mRegistration)
Attachment #8539241 - Flags: review?(amarchesini) → review+
Flags: needinfo?(nsm.nikhil)
https://hg.mozilla.org/mozilla-central/rev/56339532dd96
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.