1113705 - Joined Room should not show any icon in the Room list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

When someone sends me an invitation to join a Room (in this scenario nobody else was there but me) I am able to enter in the Room and when I leave that room, I can see in the Room list that the Room that I have just left is still occupied (blue Room icon in my Room list). But the room is really empty :(

Comment 1

[Maria Angeles Oteo (:oteo)]

Renaming the title of this bug after checking with Pau and Monica that joined Rooms should never have an icon in the Room list as the invited user as soon as he left the room he's not aware of what happens in that Room.

See WF in http://j.mp/loopwfs, Home Loop -> Rooms and Visual Rooms_log.v1.png in https://app.box.com/s/jt5v3rnvv3vqtyoj1n52/1/2717236524/24222713435/1 .

Comment 2

[Maria Angeles Oteo (:oteo)]

Arnau is working also in bug 1113151 - Adapt Room list screen to the visual proposal, please be aware of it to decide if Arnau implement it on this bug or it's better to handle separately.

Comment 3

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8540160 [details] [review]
Pull Request

LGTM, landing because you are in PTO thought, thanks a lot

Comment 5

[Cristian Rodriguez (:crdlc)]

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/70669f66d570301332a9edc7d14de14526c4c993

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Clearing ni as the patch is resolved ;)