1113151 - Adapt Room list screen to the visual proposal

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Attachment: 2014-12-16-19-32-50.png

Pau wants to provide feedback about the implementation of the Room list screen.

Comment 1

[Pau Masiá [:Pau]]

Attachment: Visual Spec_RoomsList

Here I attach a spec in which you can see the proper way to implement the UI.
I've seen there are some issues regarding font alignment, spacing and the height of the row. 

In case the name of the participant is too long we should add an ellipsis instead of making the row grow.

Thanks!

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

gracias

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8539180 [details] [review]
Github pull request

Arnau is working on parallel on this bug according to Pau. Please next time update the "assign" field when the implementation starts

Comment 4

[Maria Angeles Oteo (:oteo)]

Arnau, be aware that Pau has released a new visual Visual Rooms_log.v1.png in https://app.box.com/s/jt5v3rnvv3vqtyoj1n52/1/2717236524/24222713435/1 where you can see several changes:

1) Room icon color is lighter in case the created Room is empty
2) In case the created Room has not been shared with any contact, a new icon (like a contact search) has been added and a message has been included (Don't be shy. Share this Room!)
3) For an invited Room, no icon is shown. This has already been reported in Bug 1113705. Align with Borja to decide if it's better that he implements it or you should do it in this bug.
4) In case a created Room is expired, include "Expired" string in the Room entry

Comment 5

[Maria Angeles Oteo (:oteo)]

Arnau, we are making easier your work in this bug :). Just to let you know that:

3) For an invited Room, no icon is shown: has already been addressed by Borja and landed in master in bug 1113705
4) In case a created Room is expired, include "Expired" string in the Room entry: "Expired" string has already been added in bug 1115014 by Cristian but it's still pending to paint it in red, as we were not sure about the exact color. So please, do it in this bug with the rest of pending work

Thanks a lot!

Comment 6

[Maria Angeles Oteo (:oteo)]

(In reply to Maria Angeles Oteo (:oteo) from comment #4)
> Arnau, be aware that Pau has released a new visual Visual Rooms_log.v1.png
> in https://app.box.com/s/jt5v3rnvv3vqtyoj1n52/1/2717236524/24222713435/1

This is the correct link: https://app.box.com/files/0/f/2717236524/1/f_24222713435

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 8

[Borja Salguero [:borjasalguero]]

Attachment: Call log updated

Comment 9

[Paco Rampas [:paco]]

Comment on attachment 8550236 [details] [review]
Pull Request

Borja, works great for me ;)

Comment 10

[Borja Salguero [:borjasalguero]]

Gracias Paco! ;)