Closed Bug 1113863 Opened 10 years ago Closed 9 years ago

Windows 7 Debug failing all tests | Exception: Sorry, cannot connect to jsbridge extension, port 24242

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 38.0

People

(Reporter: rkent, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 1 obsolete file)

Fix
2.87 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review
Moving application configure after exporting MOZ_NO_DEBUG_RTL
3.40 KB, patch
glandium
: review+
Callek
: feedback+
Details | Diff | Splinter Review 
jcranmer suspects this is associated with config change:

12:03:46 PM - jcranmer|away: oh, I think I know why
12:03:54 PM - jcranmer|away: and it's because autoconf is a $!@#%^&ing pain in the butt
12:04:22 PM - jcranmer|away: http://dxr.mozilla.org/comm-central/source/mail/configure.in#95
12:04:33 PM - jcranmer|away: the variable that's checking isn't defined until after that code is invoked
12:04:39 PM - jcranmer|away: so it's not properly triggering
Said variable is declared here: <http://dxr.mozilla.org/comm-central/source/mozilla/configure.in#7257>

mail/configure.in is declared here: <http://dxr.mozilla.org/comm-central/source/mozilla/configure.in#4106>

Hence we're attempting to use a variable prior to its definition.
Keywords: intermittent-failure
Summary: Windows 7 Debug failing all tests → Windows 7 Debug failing all tests | Exception: Sorry, cannot connect to jsbridge extension, port 24242
FYI:
https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=40af2c0566fd

Unfortunately adding --disable-debug-rtl option for ldap c-sdk did not solve this failure.
Just FYI.

I can't see any significant difference except debug symbol handling between them.
Attached patch Fix — — Splinter Review 
USE_DEBUG_RTL was used even if --disable-debug-rtl option is set.

This patch is equivalent to nspr change. 
https://hg.mozilla.org/mozilla-central/rev/8bc3daaf84cc
Assignee: nobody → hiikezoe
Attachment #8544326 - Attachment is obsolete: true
Attachment #8544341 - Flags: review?(Pidgeot18)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #56)
> Created attachment 8544341 [details] [diff] [review]
> Fix
> 
> USE_DEBUG_RTL was used even if --disable-debug-rtl option is set.

Oops! This patch is not a fix for this issue, I think. This patch does just fix the case of setting --disable-debug-rtl.
A try on comm-central:

https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=4580ff11b093

and try on mozilla-central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=175185d3eb70


This patch solved the failure on try server.
I am not sure this patch has no side-effect against seamonkey.
Attachment #8544485 - Flags: feedback?(philip.chee)
Attachment #8544485 - Flags: feedback?(Pidgeot18)
Comment on attachment 8544485 [details] [diff] [review]
Moving application configure after exporting MOZ_NO_DEBUG_RTL

(In reply to Hiroyuki Ikezoe (:hiro) from comment #59)
> Created attachment 8544485 [details] [diff] [review]
> Moving application configure after exporting MOZ_NO_DEBUG_RTL
> 
> A try on comm-central:
> 
> https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-
> central&revision=4580ff11b093
> 
> and try on mozilla-central:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=175185d3eb70
> 
> This patch solved the failure on try server.
> I am not sure this patch has no side-effect against seamonkey.
I am sorry but build config is outside my area of competence.
I'll set the feedback? flag to :callek
Attachment #8544485 - Flags: feedback?(philip.chee) → feedback?(bugspam.Callek)
Comment on attachment 8544485 [details] [diff] [review]
Moving application configure after exporting MOZ_NO_DEBUG_RTL

Review of attachment 8544485 [details] [diff] [review]:
-----------------------------------------------------------------

I can't find anything that says this would hurt seamonkey at a glance. I can't test anytime soon though easily.

That said, http://mxr.mozilla.org/comm-central/source/mail/configure.in#96 will probably need to be ported for SeaMonkey (suite/configure.in) as well.
Attachment #8544485 - Flags: feedback?(bugspam.Callek) → feedback+
Attachment #8544485 - Flags: feedback?(Pidgeot18) → review?(mh+mozilla)
Comment on attachment 8544485 [details] [diff] [review]
Moving application configure after exporting MOZ_NO_DEBUG_RTL

Review of attachment 8544485 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather move export MOZ_NO_DEBUG_RTL=1.
Attachment #8544485 - Flags: review?(mh+mozilla) → review-
(In reply to Mike Hommey [:glandium] from comment #67)
> Comment on attachment 8544485 [details] [diff] [review]
> Moving application configure after exporting MOZ_NO_DEBUG_RTL
> 
> Review of attachment 8544485 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'd rather move export MOZ_NO_DEBUG_RTL=1.

That has no unknown side effects, while moving app subconfigure does.
(In reply to Mike Hommey [:glandium] from comment #67)
> Comment on attachment 8544485 [details] [diff] [review]
> Moving application configure after exporting MOZ_NO_DEBUG_RTL
> 
> Review of attachment 8544485 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'd rather move export MOZ_NO_DEBUG_RTL=1.

You mean also moving jemalloc check and something related codes?
ah, that's in a MOZ_MEMORY block... sigh, what a mess.
Comment on attachment 8544485 [details] [diff] [review]
Moving application configure after exporting MOZ_NO_DEBUG_RTL

Review of attachment 8544485 [details] [diff] [review]:
-----------------------------------------------------------------

Let's go with this, then, hoping app configures are not relying on anything above their new point of entry happening after them.
Attachment #8544485 - Flags: review- → review+
Comment on attachment 8544341 [details] [diff] [review]
Fix

Review of attachment 8544341 [details] [diff] [review]:
-----------------------------------------------------------------

Is this needed, given https://bug1113863.bugzilla.mozilla.org/attachment.cgi?id=8544485 ?
(In reply to Joshua Cranmer [:jcranmer] from comment #125)
> Comment on attachment 8544341 [details] [diff] [review]
> Fix
> 
> Review of attachment 8544341 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is this needed, given
> https://bug1113863.bugzilla.mozilla.org/attachment.cgi?id=8544485 ?

Yes. I did run a try to make sure win debug build fails without attachment 8544341 [details] [diff] [review].
https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=6ef10530ae0d
(In reply to Hiroyuki Ikezoe (:hiro) from comment #128)
> (In reply to Joshua Cranmer [:jcranmer] from comment #125)
> > Comment on attachment 8544341 [details] [diff] [review]
> > Fix
> > 
> > Review of attachment 8544341 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Is this needed, given
> > https://bug1113863.bugzilla.mozilla.org/attachment.cgi?id=8544485 ?
> 
> Yes. I did run a try to make sure win debug build fails without attachment
> 8544341 [details] [diff] [review].

Precisely, with 8544485, without attachment 8544341 [details] [diff] [review].
Attachment #8544341 - Flags: review?(Pidgeot18) → review+
Keywords: checkin-needed
Whiteboard: [checkin-needed: m-c and c-c]
https://hg.mozilla.org/integration/mozilla-inbound/rev/01644d704dcf


I thought this would be an easy push, but attachment 8544341 [details] [diff] [review] needs to be pushed to https://hg.mozilla.org/projects/ldap-sdks/ which is tagged as LDAPCSDK_6_0_7G_RTM in client.py. Do I need to retag this, and if so do I use the same tag or do I up one of the numbers? I won't be sad if someone who knows what he is doing takes over.
Keywords: leave-open
Whiteboard: [checkin-needed: m-c and c-c] → [checkin-needed: sdks repo]
https://hg.mozilla.org/mozilla-central/rev/01644d704dcf
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Blocks: 1131158
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: