1114051 - [E10s] Right click on a link

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[herdir]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141220030202

Steps to reproduce:

Right click on a link. If E10s is not activate, it work fine.


Actual results:

The options "Open link in a new tab, open link in new window and open link in new private window"  doesn't work. Nothing happen when clicking on this buttons.


Expected results:

It should open link in a new tab or  open link in new window or open link in new private window.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Confirming. From error console:

Error: NS_ERROR_XPC_CANT_PASS_CPOW_TO_NATIVE: It's illegal to pass a CPOW to native code arg 0 [nsIScriptSecurityManager.getAppCodebasePrincipal]
Source File: chrome://browser/content/nsContextMenu.js
Line: 832

Comment 2

[Alice0775 White]

Pushlog
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=00da5b2f2bcb&tochange=06d89851a3a5

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-context-menu

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Also, it failed because the URI argument to getAppCodebasePrincipal is an nsIURI CPOW. I could have made it a local URI, but this seems like a better fix.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8539717 [details] [diff] [review]
fix-context-menu

Review of attachment 8539717 [details] [diff] [review]:
-----------------------------------------------------------------

This looks right to me - thanks billm.

Comment 12

[Gian-Carlo Pascutto [:gcp]]

Bit surprised we don't have test coverage for this.

Comment 16

[iamjayakumars]

Works fine after latest Nightly update 

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:37.0) Gecko/20100101 Firefox/37.0 ID:20141222030202 CSet: b915a50bc6be

Comment 17

[Andrew McCreight [:mccr8]]

It looks like this was probably fixed via backout of bug 1072980.

Comment 19

[Matthias Versen [:Matti]]

The fix from bug 1072980 is back in and this bug is back

Comment 20

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Matthias Versen [:Matti] from comment #19)
> The fix from bug 1072980 is back in and this bug is back

Please post more details then. I just tested and the problem in comment 0 is fixed for me.

Comment 21

[Matthias Versen [:Matti]]

sorry for the noise, i mixed "link" and "Image"