1114589 - crash in java.lang.NoSuchMethodError: android.net.Uri.getQueryParameterNames at org.mozilla.search.PostSearchFragment$ResultsWebViewClient.shouldOverrideUrlLoading(PostSearchFragment.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

This bug was filed from the Socorro interface and is 
report bp-8c7e4c05-4f71-4051-8e2f-edbcc2141222.
=============================================================
Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 37.0a1 (2014-12-21);

Steps to reproduce:
1. Launch Search Activity;
2. Perform a search;
3. Go to the second page of results.

Expected result:
The second page of results is successfully loaded.

Actual result:
Fennec crashes.


Stacktrace:
java.lang.NoSuchMethodError: android.net.Uri.getQueryParameterNames
	at org.mozilla.search.PostSearchFragment$ResultsWebViewClient.shouldOverrideUrlLoading(PostSearchFragment.java:106)
	at android.webkit.CallbackProxy.uiOverrideUrlLoading(CallbackProxy.java:225)
	at android.webkit.CallbackProxy.handleMessage(CallbackProxy.java:348)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3691)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:907)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:665)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[:Margaret Leibovic]

Sigh, getQueryParameterNames is API 11:

http://developer.android.com/reference/android/net/Uri.html#getQueryParameterNames%28%29

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1114589/margaret

Comment 3

[:Margaret Leibovic]

/r/1633 - Bug 1114589 - Add compatibility layer for Uri.getQueryParameterNames. r=rnewman

Pull down this commit:

hg pull review -r 3b7d1fa11409cf3de9855df3a6575319b5a6f93c

Comment 4

[Richard Newman [:rnewman]]

https://reviewboard.mozilla.org/r/1631/#review1031

I'm surprised there was no IDE warning for that compat issue :/

This looks good.

As a sidenote, I'm not sure if there's a ProGuard-friendly choice for how to do this, between:

```
public Foo bar(Boz boz) {
  if (Versions.feature11Plus) {
    return boz.bar();
  }
  …
}

…
  return Utils.bar(boz);
```

and

```
public Foo bar(Boz boz) {
  …
}

…
  if (Versions.feature11Plus) {
    return boz.bar();
  } else {
    return Utils.bar(boz);
  }
```

Certainly the former is more foolproof, but perhaps less likely to be inlined or eliminated?

Comment 5

[Richard Newman [:rnewman]]

https://reviewboard.mozilla.org/r/1631/#review1033

Ship It!

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/9d54f4c91c31

Comment 7

[:Margaret Leibovic]

Comment on attachment 8540252 [details]
MozReview Request: bz://1114589/margaret

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: crash for gingerbread users
[Describe test coverage new/current, TBPL]: no automated tests, tested locally
[Risks and why]: low-risk, add compatibility method for API not included on older versions of Android
[String/UUID change made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d54f4c91c31

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eceec05a2ab2
https://hg.mozilla.org/releases/mozilla-beta/rev/ffd80298cdcb

Comment 10

[Ioana Chiorean]

Devices: Galaxy Nexus ( 4.3) HTC Desire S (2.3), galaxy R (2.3)
Nightly 2014-12-23
Aurora  2014-12-23
Beta 35 Beta 6 build 1

Ii am not able to reproduce the crash using the steps from description ( #c0)

> Steps to reproduce:
> 1. Launch Search Activity;
> 2. Perform a search;
> 3. Go to the second page of results.

MArking it as VERIFIED FIXED

Comment 11

[Flaviu Cos]

Based on comment 10 will change the flags to verified.

Comment 13

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1114589 - Add compatibility layer for Uri.getQueryParameterNames. r=rnewman