1114712 - l10n module doesn't get any language on Linux

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Martin Giger [:freaktechnik]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141127111021

Steps to reproduce:

While running tests with jpm on my linux system, I noticed that it warned about not having any plural rules for the language "null". I dug into code and quickly found out, that the default value of the pref indicating the locales used for web content is localized under linux. However the l10n/locale module does not account for that and ends up not finding any locale.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Pull Request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8540291 [details] [review]
Pull Request

looks good thanks!

this needs a test however.

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 8540291 [details] [review]
Pull Request

I've added a test, which checks the functionality of the method when the pref for content locales is localized and not just a string.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8540291 [details] [review]
Pull Request

Looks good!  just mentioned a minor thing about using `.trim()` instead of `.replace(...`.

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 8540291 [details] [review]
Pull Request

Addressed the changes suggested by evold.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/504e53cf5cd4c658f9931e79ef2d02fdab2a2228
Bug 1114712 Add tests

https://github.com/mozilla/addon-sdk/commit/ee7083842ce810a67e2d84254a7e42bfdff14e74
Merge pull request #1762 from freaktechnik/fix-locale-detection

Bug 1114712 - l10n module doesn't get any language on Linux r=erikvold