1115014 - Improve the behavior when joining to a deleted Room

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Tested with master Loop client (future 1.1.1 release) and latest 2.0 FxOS version

STR:
1. Contact A creates a Room1 and shares it with Contact B.
2. Contact B joins and leaves Room1, so Room1 appears as an entry in the Device B Room list.
3. Contact A (owner) deletes Room1
4. Contact B try to joins Room1

Actual Result:
After trying to join the Room screen is closed and the confirmation message "Oops! That didn't work as expected. Why don't we give it another try?

Expected Result: 
I think that this is message is not enough clear for the user.

After talking with Mónica, we think that a better feedback should be given. 
Perhaps a better message could be something like: 
"This Room no longer exists, do you want to delete it from your Room list?
and the user could decide to delete it or cancel the action and in that case the Room could be updated as "Expired" in the Room list

Comment 1

[Maria Angeles Oteo (:oteo)]

Monica, let's know when you update the WF with the complete flow. Thanks a lot!

Comment 2

[Maria Angeles Oteo (:oteo)]

Monica has updated the WF including this case http://j.mp/loopwfs -> New Room - Join + Communication
The new screen Join in Room - Deleted room, will show the message "Oops... You can't join because owner has deleted this room. Do you want to delete it from your room list?" with the options "Cancel" and "Delete".

In case option "Delete" is pressed, the room will be deleted (not necessary to show the banner in this case) and we go back to the Room list 
In case "Cancel" is selected, the Room list is shown again but the Room will be updated with "Expired" (in case it was not updated before)

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[Maria Angeles Oteo (:oteo)]

Comment on attachment 8545995 [details] [review]
Github pull request

Working perfect, as usual!

Just one comment, after rechecking the WFs, I think that it's more correct to say:"// Oops... You can't join because THE owner has deleted this room. 
Do you want to delete it from your room list?

Anyway, I'll confirm it with Monica now, I'll let you know in the bug

Comment 5

[Mónica UX/UI]

Hey!
Yep MA! It's true!
"Oops... You can't join because the owner has deleted this room. Do you want to delete it from your room list?" it's better.

Thanks everybody :)

Comment 6

[Cristian Rodriguez (:crdlc)]

Updated the string

(In reply to Mónica UX/UI from comment #5)
> Hey!
> Yep MA! It's true!
> "Oops... You can't join because the owner has deleted this room. Do you want
> to delete it from your room list?" it's better.
> 
> Thanks everybody :)

Comment 7

[Maria Angeles Oteo (:oteo)]

Last change in last minute: After talking with Mónica and Cristian, instead of including the string "Expired" in the Room list, it should be "Deleted" when trying to join an already deleted Room.

Pau, could you please provide the exact font color for this? Thanks a lot!

Comment 8

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/efbe702e0a35491c22e7b45dc59f95b4cb33336e

Comment 9

[Pau Masiá [:Pau]]

Hey MA, sure! Here it is: #d74345.