1115109 - [Calendar][RTL] When adding an event to Calendar, the blue arrow will overlap the time, when adding the time of the event

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[[:SalvadorR]]

Attachment: CalendarTime.png

Description:
When user adds an event in the Calendar app, the time of when the event starts will overlap the blue arrow when adjusting the time of when the event will start
   
Repro Steps:
1) Update a Flame device to BuildID: 20141223010202
2) Open Calendar app
3) Add an event
4) Observe the blue arrow where user can change the time of the event
  
Actual:
Blue arrow overlaps the time of the event
  
Expected: 
no overlap occurs
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141223010202
Gaia: c2da2bafd4e809317e2ca70c9bf5c11136a32818
Gecko: 0532f2509f3f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 3/3
See attached: Screenshot, Logcat

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1115109 to mozilla-b2g:master

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8547217 [details] [review]
[PullReq] anefzaoui:bug-1115109 to mozilla-b2g:master

Please review?
Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8547217 [details] [review]
[PullReq] anefzaoui:bug-1115109 to mozilla-b2g:master

Miller - could I pass this review off to you?

Comment 4

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8547217 [details] [review]
[PullReq] anefzaoui:bug-1115109 to mozilla-b2g:master

LGTM. simple change and solves the problem.

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27301

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #5)
> https://github.com/mozilla-b2g/gaia/pull/27301
> 
> The pull request could not be applied to the integration branch. Please try
> again after current integration is complete.

Cleared this up on IRC with Ahmed - but this is happening because Autolander can't land code when the tree is closed. I need to adjust the message in this case.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/33c0b3aa616ef20889c76a88160614491ee2a646

Comment 8

[Elie]

Hi Ahmed
This issue still exist on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Reproduce rate  5/5
Happen time     2:25
Refer to picture 2015-01-19-02-25-44.png and logcat.txt. 
Description:When user adds an event in the Calendar app, the time of when the event starts will overlap the blue arrow when adjusting the time of when the event will start.
Expected: 
no overlap occurs

Comment 9

[Elie]

Attachment: 2015-01-19-02-25-44.png

Comment 10

[Elie]

Attachment: logcat.txt

Comment 11

[Ahmed Nefzaoui [:Nefzaoui]]

Aware of this, and will be handled with a request to uplift.

Comment 12

[bhavana bajaj [:bajaj]]

:kaze, can this be uplift to 2.2 ?

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

@Elie: please make sure that patches on master have actually landed on 2.2 before reopening a bug for 2.2. We are seeing a few cases where bugs are reopened, but it's just a matter of uplifting the patch from master to 2.2. Please take into account for next time as this creates too much noise otherwise. Thanks!
@Josh and Elie: can you make sure to communicate this out to Marigold testers please? thanks!

Comment 14

[Elie]

(In reply to Delphine Lebédel [:delphine - use need info] from comment #13)
> @Elie: please make sure that patches on master have actually landed on 2.2
> before reopening a bug for 2.2. We are seeing a few cases where bugs are
> reopened, but it's just a matter of uplifting the patch from master to 2.2.
> Please take into account for next time as this creates too much noise
> otherwise. Thanks!
> @Josh and Elie: can you make sure to communicate this out to Marigold
> testers please? thanks!

OK Thanks for your reply.I will make sure that patches on master have actually landed on 2.2 before reopen a issue.

Comment 15

[Fabien Cazenave [:kaze]]

Comment on attachment 8547217 [details] [review]
[PullReq] anefzaoui:bug-1115109 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): ?
[User impact] if declined: incorrect text alignment in Calendar for RTL users
[Testing completed]: manual, latest Gecko & Gaia
[Risk to taking this patch] (and alternatives if risky): none — this is just a trivial CSS update
[String changes made]: none

Comment 17

[Miller Medeiros [:millermedeiros]]

landed on v2.2: https://github.com/mozilla-b2g/gaia/commit/b30c8e4303595a0fcb5b640d673cf8503b954701

Comment 18

[Sue]

Attachment: 2015-02-12-09-47-54.png

This issue has been verified successfully on Flame v2.2
STR:
1. Open Calendar app
2. Add an event
3. Observe the blue arrow where user can change the time of the event
**no overlap occurs
See attachment:2015-02-12-09-47-54.png
Rate:0/5

Flame 2.2 build:
Build ID               20150211002505
Gaia Revision          943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gaia Date              2015-02-11 08:01:09
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e614443583e7
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150211.040242
Firmware Date          Wed Feb 11 04:02:53 EST 2015
Bootloader             L1TC000118D0

Comment 19

[Sue]

This issue has been verified successfully on Flame v3.0
STR:
1. Open Calendar app
2. Add an event
3. Observe the blue arrow where user can change the time of the event
**no overlap occurs
Rate:0/5

Flame 3.0 build:
Build ID               20150211010216
Gaia Revision          8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gaia Date              2015-02-10 17:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ee093ca70666
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150211.043725
Firmware Date          Wed Feb 11 04:37:36 EST 2015
Bootloader             L1TC000118D0

Comment 20

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15876/