1115173 - [RTL][Settings] Back button is reversed when managing networks

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Seth Miko [:SMiko]]

Attachment: ReversedBackButton.png

Description: The back arrow is reversed when managing wifi networks in Settings. 

Repro Steps:
1: Update a Flame to 20141223010202
2: Set language to Arabic.
3: Open Settings > Wifi > Manage Networks

Actual: The back button displays as ">"

Expected: The back button displays as "<"

Environmental Variables:
Device:Flame 2.2 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141223010202
Gaia: c2da2bafd4e809317e2ca70c9bf5c11136a32818
Gecko: 0532f2509f3f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro Rate: 5/5

See attached screenshot

Comment 1

[Delphine Lebédel [:delphine - OOO]]

Ahmed: is this a bug or a feature? I know UX wanted to implement some kind of solution to differentiate header directions vs the rest. Not sure about this, though

Comment 2

[Yeojin Chung [:YeojinC]]

Attachment: SimPinBackButton.png

This issue also occurs in SIM Security > SIM PIN.

Comment 3

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

This is a bug based on the latest BDI spec.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/27736

EJ, mind take a look at this patch? I'm not sure why we use `openDialog` to open these panels, so I simply replace these calls using `SettingsService.navigate`. For the select certificate panel, I filed bug 1126706 and bug 1126708 as it is actually a dialog and we should migrate to use `DialogService`.

Comment 6

[Stephany Wilkes]

This is a bug, as the back button is not changing for 2.2, per the 2.2 spec. Thanks for filing!

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The submenu back buttons in the settings are in the wrong location/pointed the wrong way and such for bidi but are in according to spec.  It really doesn't make sense with the animation...  :(

Will this get fixed in 2.2+?

Comment 8

[Stephany Wilkes]

The submenu back buttons are changing in another bug. There is a new visual treatment. The original bug filed, however, was not about submenu buttons. Please open another for any submenu bugs; original bug was about the header.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8555735 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/27736

I just noticed that bug 1126708 are trying to remove the last piece of "SettingsUtils.openDialog", so Arthur, you can choose which bug is the last one to be landed, and remember to remove "SettingsUtils.openDialog" !

(BTW, for the last bug, we can try to remove all data-l10n-id at once !)

Thanks ! r+ :)

Comment 10

[Shine(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15567/

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ!

master: 18dc296f6ec3b816309f4c3cd718904897ea5404

Comment 12

[Sue]

Attachment: E-Mail_backbutton.png

The back button "<" in E-Mail app settings are also shown as ">".
See attachment:E-Mail_backbutton.png

Flame 2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be206fa2fb60
Build-ID        20150202002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150202.035604
FW-Date         Mon Feb  2 03:56:15 EST 2015
Bootloader      L1TC000118D0

Comment 13

[Sue]

Attachment: Settings_backbutton.png

This issue has been verified successfully on Flame v3.0, back button is correct when managing networks.
1. Set language to Arabic.
2. Open Settings > Wifi > Manage Networks.
**The back button displays as "<".
See attachment:Settings_backbutton.png
Rate:0/5

Flame 3.0 build:
Gaia-Rev        ab69ae06a7f2b54e60ab63b1b44c8d19d5d20d94
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/c2359a6a6958
Build-ID        20150201010217
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.044915
FW-Date         Sun Feb  1 04:49:25 EST 2015
Bootloader      L1TC000118D0

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8555735 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/27736

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Leads to bad user experience
[Testing completed]: Testing on the device
[Risk to taking this patch] (and alternatives if risky): None, it simply changed to use gaia component.
[String changes made]: N/A

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/df271a0088784f3f76be134413da52fa46af3668

Comment 16

[Sue]

Attachment: verify.png

This issue has been verified successfully on Flame v2.2, back button is correct when managing networks.
1. Set language to Arabic.
2. Open Settings > Wifi > Manage Networks.
**The back button displays as "<".
See attachment:verify.png
Rate:0/5

Flame 2.2 build:
Build ID               20150204162500
Gaia Revision          c2047a46e29696238e9b4c9caaba47736421449a
Gaia Date              2015-02-04 20:34:04
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.195445
Firmware Date          Wed Feb  4 19:54:56 EST 2015
Bootloader             L1TC000118D0