1102138 - [gaia-header] Should no longer reverse content in RTL mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Comment 3

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Updates gaia-header to v0.5.0, which includes the removal of RTL logic.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Dec 30)]

Comment on attachment 8526711 [details] [review]
pull-request (master)

r=me with the small nits and one question to answer about calculating shadowCss.

I'm always wary of executing things when the script is just executed, but since it's not the goal of this patch let's move forward and handle this separately.

Maybe we should ask a review from a peer for Music as well?

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8526711 [details] [review]
pull-request (master)

Updated patch to address comments. Just waiting on green.

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8526711 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/98d629bfa1bc9e47aa0b6ae6381c6d626b5b75ba

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Dec 30)]

Landed in Gaia master: 2cb461dde5b9430ed87919e768de8c1cea503db6

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Dec 30)]

Mmm sorry, wrong bug, forget me :)

Comment 11

[Shine(Leave from Mozilla)]

Attachment: Screenshot

This problem is verified pass on latest build of Flame2.2. On Contacts list view, the header is not reverse in RTL mode.
See attachment: English&Arabic_Screenshot.PNG
Reproduce rate 0/5

Flame 2.2 build:
Gaia-Rev        0518f4581a0925c0b703d730ef289ab15cbd1216
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967
Build-ID        20150126002536
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150126.042138
FW-Date         Mon Jan 26 04:21:49 EST 2015
Bootloader      L1TC000118D0

Comment 12

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15382/