Closed Bug 1102138 Opened 5 years ago Closed 5 years ago
[gaia-header] Should no longer reverse content in RTL mode
No description provided.
Updates gaia-header to v0.5.0, which includes the removal of RTL logic.
Attachment #8526711 - Flags: review?(felash)
Comment on attachment 8526711 [details] [review] pull-request (master) r=me with the small nits and one question to answer about calculating shadowCss. I'm always wary of executing things when the script is just executed, but since it's not the goal of this patch let's move forward and handle this separately. Maybe we should ask a review from a peer for Music as well?
Attachment #8526711 - Flags: review?(felash) → review+
Comment on attachment 8526711 [details] [review] pull-request (master) Updated patch to address comments. Just waiting on green.
Comment on attachment 8526711 [details] [review] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/98d629bfa1bc9e47aa0b6ae6381c6d626b5b75ba
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Landed in Gaia master: 2cb461dde5b9430ed87919e768de8c1cea503db6
Mmm sorry, wrong bug, forget me :)
This problem is verified pass on latest build of Flame2.2. On Contacts list view, the header is not reverse in RTL mode. See attachment: English&Arabic_Screenshot.PNG Reproduce rate 0/5 Flame 2.2 build: Gaia-Rev 0518f4581a0925c0b703d730ef289ab15cbd1216 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c6aa604a7967 Build-ID 20150126002536 Version 37.0a2 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150126.042138 FW-Date Mon Jan 26 04:21:49 EST 2015 Bootloader L1TC000118D0
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15382/
You need to log in before you can comment on or make changes to this bug.