1115297 - Create b2g-manifest v2.1s branch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Vincent Liu[:vliu]]

This bug is for creating manifest for 2.1s.

Comment 1

[Vincent Liu[:vliu]]

Attachment: URL_need_to_branch_out_for_v2.1s.patch

The attached file is URL list we need to branch out.

Comment 2

[Vincent Liu[:vliu]]

Attachment: Create_manifest_for_v2.1s.patch

Hi Seinlin,

The attached patch file is for creating manifest files for v2.1s. Please have a review. Thanks

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8541133 [details] [diff] [review]
Create_manifest_for_v2.1s.patch

Review of attachment 8541133 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Hwine, do you think we should create device branch for all related repos as attach patch? Or we only need to branch out those repos which get differences between 2.1 and 2.1s?

Thanks!

Comment 4

[Hal Wine [:hwine] use NI!]

Comment on attachment 8541133 [details] [diff] [review]
Create_manifest_for_v2.1s.patch

:kli - we (firefox release engineering) do not get involved with b2g manifests. Redirecting review to :mwu who can update you on gaia branching policies.

Comment 5

[Vincent Liu[:vliu]]

(In reply to Hal Wine [:hwine] (use needinfo) from comment #4)
> Comment on attachment 8541133 [details] [diff] [review]
> Create_manifest_for_v2.1s.patch
> 
> :kli - we (firefox release engineering) do not get involved with b2g
> manifests. Redirecting review to :mwu who can update you on gaia branching
> policies.

Hi :mwu,
Could you please help me to review the patch? Thanks.

Comment 6

[Hema Koka [:hema]]

(In reply to Vincent Liu[:vliu] from comment #5)
> (In reply to Hal Wine [:hwine] (use needinfo) from comment #4)
> > Comment on attachment 8541133 [details] [diff] [review]
> > Create_manifest_for_v2.1s.patch
> > 
> > :kli - we (firefox release engineering) do not get involved with b2g
> > manifests. Redirecting review to :mwu who can update you on gaia branching
> > policies.
> 
> Hi :mwu,
> Could you please help me to review the patch? Thanks.

mwu should be back from vacation tomorrow 1/6

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 8541133 [details] [diff] [review]
Create_manifest_for_v2.1s.patch

I think jhford is more familiar with how branches are actually done. I don't think a review is usually involved, or at least I've never seen one come my way before for a branch fork.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Michael, Thanks!

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

James, In the patch you can see we need to branch out about 55 repos, but actually there are only a few repos get differences between v2.1 and v2.1s, such gecko, gaia and gonk-misc. 

Do you think we need to branch out all or only those repos which get differences?

In my opinion, I think both methods are fine and the reason are:
1. Branch out all repos, device manifest will be simple only get revision=v2.1s, but need to maintain more repos with 2.1s branch.
2. Branch out few repos, device manifest will include revision=v2.1 and revision=v2.1s, but only need to maintain few repos with 2.1s branch.

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 8541133 [details] [diff] [review]
Create_manifest_for_v2.1s.patch

Assuming that all the branches in these repositories were actually created this looks fine to me!

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

Michael, When I try to create devices' branch v2.1s and I found that I didn't get access to to following repos. Could you do me a fever? Thanks!

--
fake-libdvm
kernel_lk
platform_bootable_recovery
platform_external_libpng
android-device-crespo4g
android-device-m4
android-device-maguro
device-flo
hardware_qcom_display
platform_external_opensans
skia-b2g-sgs2

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

Branch v2.1s for all related repos are created.

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/b2g-manifest/commit/14eb0516afe8bb56b6f0bca504be635ade8c0700