Closed Bug 1115404 Opened 10 years ago Closed 10 years ago

More pref changes are required for cfx test and travis suite

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(2 files, 1 obsolete file)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1767
46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
https://github.com/mozilla/addon-sdk/pull/1798
46 bytes, text/x-github-pull-request
zombie
: review+
Details | Review
See https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing#Need_to_set_preferences_for_test-suites.3F And bug 1023483. After dealing with bug 1115383, in irc: <philor> and for the underlying reason why you got broken, bug 1023483 Basically, we need to set more prefs as listed above in order to prevent random failures like this from occurring again.
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8541299 - Flags: review?(evold)
Attachment #8541299 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/c9e8f39efe3420c0a4a77cc92490eb93e2953aeb bug 1115404 - disable geoip+wifi lookup during tests https://github.com/mozilla/addon-sdk/commit/3156cab86d24c4346910bb7cce9c365a0ee400cd Merge pull request #1767 from zombie/1115404-disable-geoip bug 1115404 - disable geoip+wifi lookup during tests, r=@erikvold
this also included changes from my PR in bug 1115383 (r=gavin).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reopening because there were more prefs that I wanted to see added here.
Assignee: tomica+amo → evold
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8543412 - Attachment is obsolete: true
Attachment #8543432 - Flags: review?(tomica+amo)
Blocks: sdk-travis
Summary: More pref changes are required for cfx test → More pref changes are required for cfx test and travis suite
Attachment #8543432 - Flags: review?(tomica+amo) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: