Closed Bug 1093385 (sdk-travis) Opened 10 years ago Closed 7 years ago

Setup Travis

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: evold, Assigned: evold)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1729
46 bytes, text/x-github-pull-request
irakli
: review-
Details | Review
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1740
46 bytes, text/x-github-pull-request
irakli
: review+
Details | Review
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1747
46 bytes, text/x-github-pull-request
irakli
: review+
Details | Review
We should setup module testing on travis to provide contributors with the ability to run our tests for their pr and show us that the tests actually pass. This should help them write tests too.
Assignee: nobody → evold
Priority: -- → P1
Depends on: 1099042
Just the test addons are tested at the moment, there is some issues with the module suite at the moment, but I'd like to land this part first.
Attachment #8526723 - Flags: review?(rFobic)
Comment on attachment 8526723 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1729 I'm r- only because there was a test disabled (not sure if that was intentional). I can live with that but we should at least have a followup bug a comment in the test pointing to it. I also have bunch of questions as not everything was clear to me. More specifically I'm little skeptical in regards to added preferences/* directory and files.
Attachment #8526723 - Flags: review?(rFobic) → review-
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/f7220b9d1ef266dad0f023e80a478db078a25d56 Bug 1093385 travis notifications go to irc.mozilla.org#jetpack now a=me
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1b48a4a821cc009ee2e5a9fdd03b5d2a0d6aa2b9 Bug 1093385 making the package.json file for the toolkit-require-reload test addon pass jpm validation a=me
Irakli r+'d this during the work week in person.
Irakli can you mark this as r+ when you get a chance?
Flags: needinfo?(rFobic)
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/70d72170580e4a99c92753d3da365d787460a5a6 Bug 1093385 re-adding the "loader" key the package.json for the addon-sdk repo (b/c cfx needs ir for some reason) a=me
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/df650fa94dddf277d8a394075c19559ef6a233dc Bug 1093385 update the places test addon to work with jpm and cfx a=me
Flags: needinfo?(rFobic)
Attachment #8533252 - Flags: review?(rFobic) → review+
Blocks: jpm
Alias: sdk-travis
Depends on: 1108785
simply using child_process spawn function for the npm test modules suite (run with `node bin/jpm-test.js --type modules`)
Attachment #8535219 - Flags: review?(rFobic)
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a715c6313bf8df35ec7d595350c2ea2372b30cba Bug 1093385 using child_process spawn function for the npm test modules suite https://github.com/mozilla/addon-sdk/commit/258dd6bdf58361d67ba2d6b254a935ae54efe503 Bug 1093385 npm test now runs the module test suite in addition to the addons test suite https://github.com/mozilla/addon-sdk/commit/68000228386794bb1350c3ee11626284f3c2d877 Merge pull request #1747 from erikvold/1093385p2 Bug 1093385 using child_process spawn function for the modules test suite a=gozala
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/122d15fdb8c4a95184ad69441db5dd8d89f39182 Bug 1093385 Adding a `--filter` option when running the module test suite with node a=me Use with `node bin/jpm-test.js --type modules --filter hotkeys`
Depends on: 1111098
Depends on: 1111115
Depends on: 1111117
Depends on: 1111118
Depends on: 1111119
Depends on: 1111120
Depends on: 1111122
Depends on: 1111124
Depends on: 1112466
Depends on: 1112772
Depends on: 1112906
Depends on: 1115391
Depends on: 1115398
Depends on: 1115400
Depends on: 1115927
Depends on: 1115928
Depends on: 1116538
Depends on: 1115404
Depends on: 1118570
Depends on: 1119073
Depends on: 1123414
Attachment #8535219 - Flags: review?(rFobic) → review+
Depends on: 1141789
Depends on: 1141791
Depends on: 1142314
Depends on: 1146545
Depends on: 1147739
Depends on: 1147741
Depends on: 1159444
Depends on: 1159442
Depends on: 1159580
Priority: P1 → --
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: