Closed Bug 1115418 Opened 9 years ago Closed 8 years ago

Cursor hotspot ignored when ICO file contains PNG data

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Version:
34 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bugzilla77, Unassigned)

References

Details

Attachments

(3 files, 2 obsolete files)

hotspot_bitmap.cur
2.19 KB, image/x-icon
Details
hotspot_png.cur
322 bytes, image/x-icon
Details
hotspot.html
1.26 KB, text/html
Details 
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36

Steps to reproduce:

http://bugs.idsl.pl/firefox/hotspot.html

Green block is associated with hotspot_bitmap.cur cursor (containing BITMAP format data).
Red block is associated with hotspot_png.cur cursor (containing PNG format data).
Both cursors look identical.
Both cursors contain binary defined hotspot 31px 31px (file char positions: 10, 12).


Actual results:

hotspot_png.cur hotspot is ignored!


Expected results:

hotspots respected
Attached image hotspot_bitmap.cur — 

    
    

    
  

      
      
      
      

        Attached image
          
        hotspot_png.cur
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached file
          
        hotspot.html (obsolete)
        — 
      

    


  

    
  

        Attachment #8541318 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        hotspot.html (obsolete)
        — 
      

    


  

    
    

    
  
Looks like nsICODecoder::WriteInternal only calls SetHotSpotIfCursor() when !mIsPNG.

Also reproducable on Linux.
Status: UNCONFIRMED → NEW
Component: Layout → ImageLib
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Summary: Cursor hotspot ignored → Cursor hotspot ignored when ICO file contains PNG data

    
    

    
  
Please note that all 3 duplicates of this bug, and this bug, were filed by the same person.

Please don't file multiple instances of the same bug in the future.

    
    

    
  
And note that bug 976522 comment 3 contains a little bit of debugging (although probably comment 8 is a better place to start).

    
    

    
  
Sorry, should be:

Both cursors contain binary defined hotspot 31px 31px (file char positions: 10-11, 12-13).

    
  

        Attachment #8541319 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        hotspot.html
        — 
      

    


  

    
    

    
  
Seems to be fixed in Firefox 44.0

Now, only problem is: hotspot_bitmap.cur is not visible
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: