1115508 - [Flame][Built-in&System Keyboard]The utility bubble always shows even at lock screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect, P2)

Description

[Sue]

Attachment: logcat_1427.txt

[1.Description]:
[Flame v2.2][Keyboard]
The utility bubble always shows even device enter sleep mode and then enter lock screen.
Found time:14:27
See attachment:1427.MP4 and logcat_1427.txt

[2.Testing Steps]: 
1. Launch the message app.
2. Tap pencil icon to edit a new message.
3. Input some characters on the "Message" field.
4. Long tap a specific character to activate text selection. 
**The utility bubble and carets show up
5. Tap power key to enter sleep mode.
6. Tap power key again.
7. Long tap home button to show card view and chose message app again.

[3.Expected Result]: 
6. The utility bubble and carets will disappear.
7. The utility bubble and carets will disappear.

[4.Actual Result]: 
6. The cursor handles are dismissed but the cut and copy button still exist.
7. The cursor handles are dismissed but the cut and copy button still exist.

[5.Reproduction build]: 
Gaia-Rev        cb1dad4881533bff9f06d47e34983c7b10c04a8c
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/b17e7747d3fb
Build-ID        20141224010204
Version         37.0a1

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: 12160

Comment 1

[Sue]

Attachment: video

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-12-26-09-43-13.png

Hi George, Could you help with this, thanks.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Sue,
The STR can

Comment 4

[Sue]

(In reply to George Duan [:gduan] [:喬智] from comment #3)
> Hi Sue,
> The STR can

Hi George,
I can't understand what you mean, could you give me detailed descriptions? Thanks!

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

oopz, I took the bug but forgot to remove original msg. sorry.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

bug 1114853 can fix this issue. We'll verify this issue once bug 1114853 and its gaia patch is landed.

Comment 7

[howie [:howie]]

ni George to verify if the bug still here, thanks

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

In this bug, gaia should listen to screenchange to close the bubble when screen is off and make sure gecko will blur original iframe once lockscreen is in the front.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch will force to blur current foreground app if screen is off and lockscreen is enbaled.

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8543927 [details] [review]
PR to master

Hi Alive,
could you review this patch?
I tried to blur foreground app when screen is off and lockscreen is enabled.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8543927 [details] [review]
PR to master

screenchange does not imply Service.locked is already set to true. What you need is call this._activeApp.blur in AppWindowManager#setHierarchy(enable = false);

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8543927 [details] [review]
PR to master

Hi Alive,
could you check it again? 
This patch will call blur and close copypaste bubble when setHierarchy(false) in appWindowManager.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8543927 [details] [review]
PR to master

See gh

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8543927 [details] [review]
PR to master

I think I should listen to hierachychanged to close the bubble and also blur the foreground app in appWindowManager#setHierachy to make sure the caret is gone.

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8543927 [details] [review]
PR to master

r=me, thanks.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks.
Master: https://github.com/mozilla-b2g/gaia/commit/96a47a083560c01fc37c96f0cd6dd2bd962f5e1e

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master, marionette test

wait for test.

Comment 18

[Kevin Grandon :kgrandon]

This started causing perma-failures on Gij1 after landing, as present in the gaia-try run.

Reverted: https://github.com/mozilla-b2g/gaia/commit/29ab8c63ebe26e7747b2b119c70946799f431a02

http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-linux64_gecko/1420685396/b2g-inbound_ubuntu64_vm-b2gdt_test-gaia-js-integration-1-bm116-tests1-linux64-build163.txt.gz

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

wait for test.

User can switch keyboard in utilityTray, so we should not blur active app while utilityTray is shown.

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8545836 [details] [review]
PR to master

Hi Alive,
I just realized that we cannot blur activeapp when utility tray is shown due due to keyboard switching case.

could you help to do the review? I also put my marionette test to it.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8545836 [details] [review]
PR to master

Please file up hierarchy manager bug to improve the module coupling.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

If you only check UtilityTray.shown in AppWindowManager, there would be a case make your check fail: AttentionWindow is opened + UtilityTray is opened - do you need to blur? The answer is yes and that's why I said this is a bad practice.

My idea to fix the coupling is separate focus from setHierarchy in HierarchyManager and treat focus as normal hierarchy events to propagate as other events like resize/home/holdhome.

That is to say, UtilityTray would have a _handle_blur or _handle_focus function and returns false if it does not want to handle the event, and then the bottom UI under utilityTray will get the next focus event in https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/hierarchy_manager.js#L168

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Agree,
merged to master: https://github.com/mozilla-b2g/gaia/commit/b3f61c3940755241a29b30ed1956ded5eefa6f3a

Follow-up bug for comment 22: bug 1119704

Comment 24

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame 2.2
See attachment:verify_video.MP4

Flame 2.2 build:
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150114.040029
FW-Date         Wed Jan 14 04:00:40 EST 2015
Bootloader      L1TC000118D0