1115565 - Correctly handle color space correction for embedded and loaded images

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Shumway, defect)

Description

[Till Schneidereit [:till]]

Images that don't contain color profile information are rendered too brightly, regardless of whether they're embedded or loaded externally. As an example, test/swfs/image-loading/image-loading.swf loads "alf.jpg". In the Flash plugin, the display matches what can be seen when loading the same file in Photoshop. Opening the jpg itself in the browser gives the same result as rendering it in Shumway.

I *think* all we need to do is check if a loaded image has a color profile and, if not, convert it to an Exif file with the sRGB color profile.

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Do you also see this with gfx.color_management.mode set to 1? Note there's a patch in bug 621474 comment #42 to treat sRGB-tagged images as untagged when CMSMode is "TaggedOnly" (gfx.color_management.mode == 2).

Comment 2

[Till Schneidereit [:till]]

(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #1)
> Do you also see this with gfx.color_management.mode set to 1? Note there's a
> patch in bug 621474 comment #42 to treat sRGB-tagged images as untagged when
> CMSMode is "TaggedOnly" (gfx.color_management.mode == 2).

I saw that option, yes (should've mentioned that, sorry). I'm afraid I don't know enough about color management to understand if that would help us at all (though I see that this patch only applies to PNG files).

I'd also kind of like to make this work in all browsers, given that it seems like it should be moderately easy to do.

Comment 3

[Till Schneidereit [:till]]

Ads being displayed in slightly wrong colors? The horror! (Yes, moving this to post-1.0.)