1115817 - Implement %TypedArray%.prototype.join

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Comment 1

[ziyunfei]

Attachment: bug-1115817-v1.patch

Comment 2

[Tom S [:evilpie]]

Comment on attachment 8541847 [details] [diff] [review]
bug-1115817-v1.patch

Review of attachment 8541847 [details] [diff] [review]:
-----------------------------------------------------------------

Great work as always.

::: js/src/builtin/TypedArray.js
@@ +186,5 @@
> +    // Step 9.
> +    var element0 = O[0];
> +
> +    // Steps 10-11.
> +    var R = (element0 === null || element0 === undefined) ? "" : ToString(element0);

element0 can't really be null or undefined, right? Because after step 8 we have at least one element, which can only be a number.

::: js/src/tests/ecma_6/TypedArray/join.js
@@ +19,5 @@
> +    assertEq(new constructor([1, 2, 3]).join(.1), "10.120.13");
> +    assertEq(new constructor([1, 2, 3]).join({toString(){return "foo"}}), "1foo2foo3");
> +    assertEq(new constructor().join(), "");
> +    assertEq(new constructor().join("*"), "");
> +    assertEq(new constructor(3).join(), "0,0,0");

Please add one test for the "special" len == 1 case.

Comment 3

[Tom S [:evilpie]]

Comment on attachment 8541847 [details] [diff] [review]
bug-1115817-v1.patch

Review of attachment 8541847 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TypedArray.js
@@ +189,5 @@
> +    // Steps 10-11.
> +    var R = (element0 === null || element0 === undefined) ? "" : ToString(element0);
> +
> +    // Steps 12-13.
> +    // Omit the 'if' clause in step 13.c, since typed arrays can not have undefined or null element.

Oh I think this should be element*s*

Comment 4

[Tom S [:evilpie]]

Comment on attachment 8541847 [details] [diff] [review]
bug-1115817-v1.patch

Review of attachment 8541847 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TypedArray.js
@@ +191,5 @@
> +
> +    // Steps 12-13.
> +    // Omit the 'if' clause in step 13.c, since typed arrays can not have undefined or null element.
> +    for (var k = 1; k < len; k++) {
> +        R = R + sep + ToString(O[k]);

While this is correct, I would prefer if you could separate this into the steps as well.

::: js/src/tests/ecma_6/TypedArray/join.js
@@ +12,5 @@
> +
> +for (var constructor of constructors) {
> +    assertEq(constructor.prototype.join.length, 1);
> +
> +    assertEq(new constructor([1, 2, 3]).join(), "1,2,3");

On test with join(undefined)

Comment 5

[ziyunfei]

Attachment: review comment addressed

Comment 6

[ziyunfei]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80d14bba7931

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c04156cefc1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c04156cefc1

Comment 9

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/37#JavaScript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/join