1115924 - InContent prefs - Eliminate double borders from buttons and links in high contrast mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

The second border is basically a transparent border that turns into a dotted one when focused. Unfortunatly, transparent turns into a visible color in HC mode.

Here's the quickest fix I could find :
menulist:not(:-moz-focusring) > hbox,
button:not(.help-button):not(:-moz-focusring) > hbox,
.text-link:not(:-moz-focusring) {
  border-style: none;
}

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

De-listing from the hard-blocker tracking since this is a polish-related bug in high-contrast mode, which is not frequently used.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: NoFocusringBorder.patch

Simply add selectors to the already existing rules.

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch

I'm not sure this is a Windows only issue. Page Colors settings are also on OSX and Linux right ? And Linux also has HC themes too.

Comment 4

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #3)
> Comment on attachment 8557631 [details] [diff] [review]
> NoFocusringBorder.patch
> 
> I'm not sure this is a Windows only issue. Page Colors settings are also on
> OSX and Linux right ? And Linux also has HC themes too.

Oh, I see there were existing rules already. Nevermind.

Comment 5

[Richard Marti (:Paenglab)]

It's a Windows only issue. Checked with page colors disabled on Linux and OS X.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch

I can't reproduce this bug using Firefox Nightly 38.0a1 (2015-02-11) on Windows 8.1 with the High Contrast White theme enabled and tabbing through the buttons as well as the clicking on the buttons.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: borders.png

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> Comment on attachment 8557631 [details] [diff] [review]
> NoFocusringBorder.patch
> 
> I can't reproduce this bug using Firefox Nightly 38.0a1 (2015-02-11) on
> Windows 8.1 with the High Contrast White theme enabled and tabbing through
> the buttons as well as the clicking on the buttons.

The screenshot is from Win 7 but I see this also under Win 8. The focus ring is good visible around the "Learn more" links and also the second border inside the menulists. The button's focusring is almost not visible because it looks like a normal 2px border but it's the 1px border plus the 1px focusring.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8557631 [details] [diff] [review]
NoFocusringBorder.patch

Review of attachment 8557631 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I can see the change now. Thanks!

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/5bf16b55dd0d

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/5bf16b55dd0d

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5bf16b55dd0d

Comment 12

[Jerod Lycett]

This is verified fixed in a QA test day.