1116091 - [Flame][Lockscreen]After reboot, the clock on LockScreen won't update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

As Bug 1115652 Comment 13, I create this bug to handle the issue individually.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

1. Remove the duplicated clock.js in LockScreen
2. Move the code to setInterval to lockscreen.js
3. Add tests.

What I'm not sure is the original code looks complicated and I don't know why, so the potential risk exists. However, if the code is majorly for statusbar, maybe for LockScreen the code in my patch is enough.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

TBPL is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=45d6bd5ff102

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/8f9412ce170991067a1a10cfaa4cba64d2034c33

I'll submit v2.1 patch ASAP.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

I just confirmed on v2.1 we have this issue, too. So I set the tracking flag.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Sorry I just too hurry to land the patch. It need an additional fix for the time issue.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

OK I've updated the patch. Would re-land it after test.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

TBPL is green again: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=727e913b2ef1

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch rev.2

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Broken since v2.0 (I suspect it was broken even before v2.0)
[User impact] if declined: Bug no fix
[Testing completed]:With some intermittent errors, re-running: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d685b9fde921
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/12d74b902d356f94837bcf0edcd4f4089f77207d

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

The patch for this bug is causing bug 1117981. I've tried to reproduce this bug (comment 0), and found out that the clock on lockscreen DOES update, it just won't update until the screen is turned off and on either by screen timeout or manually.

Observed behavior: After reboot (with a SIM inserted but NOT connected to internet), I'm seeing this bug 1061797 where the time and date is completely wrong, and this incorrect time won't update at all until screen is turned off and on again.

This bug is perhaps another iteration of bug 1061797, or could be a separate bug.

Also, 2.0 is affected - time on lockscreen only starts to update (to the correct time) after screen off/on after reboot.

Comment 12

[bhavana bajaj [:bajaj]]

Given this is not a new regression in 2.1 plus keeping in mind the fallouts of this landing, lets not uplift this to 2.1 and this bug can get addressed in 2.2. Please Ni me if I am missing to consider any other data point for uplifting this to 2.1

Comment 13

[KTucker [:KTucker][Inactive 3/4/2016]]

I'm removing the keyword qawanted since I don't see a request here. Please re-add it if i am incorrect.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Let's make smoketest of Bug 1117981 happy again: 

Revert "Merge pull request #27052 from snowmantw/bug1116091-rev2" 
https://github.com/mozilla-b2g/gaia/commit/753e6b06b2d234129c3563d97050d3b59ac01d30

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8542466 [details] [review]
Patch v2.1

Let's reset the patching status.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

This long video shows my new WIP patch can fix this bug without result in regression like Bug 1117981, since I walked through the whole flow Bug 1117981 described, and there is no such bug.

https://www.youtube.com/watch?v=5bCQIGUBCp0

One thing interesting is both Statusbar and LockScreen would have 'two minutes' leaping issue. So what I do is make sure LockScreen works as Statusbar, which people like to compare it with LockScreen.

I'm now investigating the 'two minutes' leaping issue, and make sure this is fixable.

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

Yes. With the current Gaia master, Statusbar has the two minutes leaping issue, too. So at least my patch strictly fixed the issue described here, but for that issue this bug doesn't cover that. I'll submit the patch with test.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

The 'two minutes' leaping on master is: after unlock the statusbar would not update clock until the second minutes passed. For example:

-- unlock --
10:23 on statusbar
(now it is 10:24)
10:23 on statusbar (incorrect)
(now it is 10:25)
10:25 on statusbar (here we have the 'two minutes leaping')
(now it is 10:26)
10:26 on statusbar (the issue had gone)

With my patch on LockScreen it has the same issue, too. To simplify the work I don't think to fix it in this bug is a good idea, I may fire another bug for it. This bug would only fix the async clock between Statusbar & LockScreen. Namely, if the patch can make LockScreen's clock works as Statusbar after rebooting, then it complete its job.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

And both the two minutes leaping would disappear after it first occurs. So I'm sure that's not a LockScreen only issue.

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Fixed in the old way. I'm sure there is no errors in Bug 1117981 (see the video). For 2.1 I would submit another similar patch later.

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

Since a bit of old I rebased the patch, and wait the Try result.

Comment 22

[Greg Weng [:snowmantw][:gweng][:λ]]

(Sorry for the typo)

Comment 23

[Greg Weng [:snowmantw][:gweng][:λ]]

OK it's green again:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=0d7c6d7b8738

Comment 24

[Greg Weng [:snowmantw][:gweng][:λ]]

On the real device it fixed the bug and no regression like the old one. So I'll land this patch.

Comment 25

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/6a3dcce45af7a3a7a04487a964ffe94e075ad9eb

I'll wait several days to make sure there is no regression like the old one, and than submit and land patches for other branches. Keep NI to remind myself.

Comment 26

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: The clock on the lockscreen updates after rebooting.
 
Device: Flame Master (319mb, full flash)
Build ID: 20150129010239
Gaia: 9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57
Gecko: 6bfc0e1c4b29
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 27

[Greg Weng [:snowmantw][:gweng][:λ]]

Clear forgotten NI.