1115652 - [Flame][Lockscreen]After reboot, the screen always stays on lock screen view.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Paladin]

Attachment: logcat_flame_0541.txt

[1.Description]:
[Flame][v2.1&2.2][Homescreen]Wait a few minutes,the screen still stays on lock screen after we set screen timeout to be "Never" and then reboot device.
Attachment: logcat_flame_0541.txt and still_higtlight.3gp
Occurrence time: 05:41

[2.Testing Steps]: 
Set up:  Set Screen timeout is Never.
1. Reboot device.
2. Wait a few minutes on lock screen view.

[3.Expected Result]: 
3. The screen should enter suspend mode.

[4.Actual Result]: 
3. The screen still stays on lock srceen view.

[5.Reproduction build]: 
Flame 2.1build:
Gaia-Rev        17c7ad2e4919a994f0844239b483116090412dee
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/39dfb662c82a
Build-ID        20141225001203
Version         34.0

Flame 2.2 build:
Gaia-Rev        ab41c35eed35404b632a4841714b81b56364ba32
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2acb12da9813
Build-ID        20141225010202
Version         37.0a1

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: Free Test

Note: If we don't reboot device, in lock screen view the screen will stay on about 10 seconds and then put out.

Comment 1

[Paladin]

Attachment: still_highlight.3gp

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I don't believe that this is a bug; I think it's by design.

Screen time out means that the screen times out to the lock screen.  If you reboot  the device and have lockscreen on in the settings (settings -> screenlock -> lock screen), it will reboot to the lock screen.  You have to unlock the phone from there and then see if the lockscreen reappears or if the screen times out.

Comment 3

[Paladin]

Agree with the comment #2, this is not a valid issue.

Comment 4

[Mike Lien[:mlien]]

Hi Greg, could you help to confirm if this behavior is expected result or not?
If screen timeout is "Never" then after reboot, the lock screen will also never timeout?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

No, it's not affected by the Display in Settings app. It's hard coded 10s in screen_manager.js, which is required by UX.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

So if you found a never timeout LockScreen, except user is dragging the slider or typing passcode, it's a bug.

Comment 7

[Mike Lien[:mlien]]

refer to comment 0 and comment 6, reopen this issue and change component to Lockccreen

Comment 8

[Mike Lien[:mlien]]

Hi Paladin, could you help to describe more detailed about this problem.
If the timeout: Never is a "must" condition to reproduce this issue?

Could you give a much clearly reproduce steps?

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

"Note: If we don't reboot device, in lock screen view the screen will stay on about 10 seconds and then put out."

Does this mean the bug only occur after reboot/fist booting?

Comment 10

[Paladin]

Hi Mike,
The timeout: Never is a “must” condition for this issue.

The detail steps as follows:
Set up: Set Screen timeout is Never.
     1. Long press Power button.
     2. Tap Restart.
     3. Wait until the device restarts and successfully enters the lock screen.
** The lockscreen will never timeout and always stays on lock screen view.

If we unlock device, and then enter lockscreen,the screen will stay on about 10 seconds and then put out.

Comment 11

[Paladin]

Hi Greg,
Yes, This issue only occur after reboot device and first enters lock screen view.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Take a look when I clear the current task queue. Keep NI to remind me.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

I've found that after rebooting:

1. Clock on LockScreen wouldn't update
2. Screen wouldn't go off until the set 5 minutes passed (so if it's Never I think here we get the bug)

However, after I pressed the power button twice, or unlock the screen and lock it again, these functions work well again.

I would take a look at the clock part, since I'm very unfamiliar with the current ScreenManager. Meanwhile, should we check if this is a regression?

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

For the clock bug I fire another one to solve it. For screen manager I've no clue. I may need to ask someone else is more familiar with the file.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

The bug is Bug 1116091.

Comment 16

[Mike Lien[:mlien]]

verify with v2.0 gaia/gecko, it also has this problem
Gaia-Rev        01c32dcdc08b3c8fc8b3082870439fa2c1089f4f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b41c344ed82d
Build-ID        20141228160215
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141228.194139
FW-Date         Sun Dec 28 19:41:50 EST 2014
Bootloader      L1TC000118D0

Comment 17

[Norry.L.F(Leave from Mozilla)]

This issue can be repro on latest Flame 2.0/2.1/2.2/3.0 build
see attachment：still_highlight.3gp

Step:
Set up:  Set Screen timeout is Never.
1. Reboot device.
2. Wait a few minutes on lock screen view.

Expected Result：
3. The screen should enter suspend mode.

Actual Result：
3. The screen still stays on lock srceen view.

Flame 2.0 version:
Build ID               20150302000457
Gaia Revision          366aaa19ac474dc58b79d62a91cff41756ae9dfe
Gaia Date              2015-02-22 20:25:01
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/1bd33f5447d2
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150302.034720
Firmware Date          Mon Mar  2 03:47:30 EST 2015
Bootloader             L1TC000118D0

Flame 2.1 version:
Build ID               20150302001220
Gaia Revision          5d3479fdd438412adee4452720856b6b771fe5cd
Gaia Date              2015-02-25 18:20:09
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/9bf4c663241f
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150302.035532
Firmware Date          Mon Mar  2 03:55:42 EST 2015
Bootloader             L1TC000118D0

Flame 2.2 version:
Build ID               20150302002504
Gaia Revision          77609916ca5ab721150fab2b7bc5c37f43ee3a5a
Gaia Date              2015-02-27 16:35:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/27ab8aa34201
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150302.042723
Firmware Date          Mon Mar  2 04:27:34 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 version:
Build ID               20150302010223
Gaia Revision          f34ce82a840ad3c0aed3bfff18517b3f6a0eb37f
Gaia Date              2015-02-27 15:48:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eea6188b9b05
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150302.043726
Firmware Date          Mon Mar  2 04:37:37 EST 2015
Bootloader             L1TC000118D0

Comment 18

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

Please make a decision to see if we want to fix on latest version or put it to backlog.
Many thanks.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

My point is the screen part should be fixed at screen manager, not lockscreen. Unless there is any advanced info indicates that the bug is caused by lockscreen. This is because I'm really unfamiliar with the code (screen manager).

Comment 20

[howie [:howie]]

Screen manager issue, can system FE take a look? thanks

Comment 21

[Gregor Wagner [:gwagner]]

Alive knows this best. Can you take a look?

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Forwarding to Evan. Please investigate and tell us what you find.

Comment 23

[Evan Tseng [:evanxd]]

Sure.

Comment 24

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29763

WIP patch, need tests.

Comment 25

[Evan Tseng [:evanxd]]

Tests added.

Comment 26

[Evan Tseng [:evanxd]]

Discussed with Alive in person, and updated patch.

Comment 27

[Evan Tseng [:evanxd]]

Updated patch.
Need to check Bug 896322 to make sure we could remove `|| !Service.currentApp` in the patch.

Comment 28

[Evan Tseng [:evanxd]]

We cannot remove `|| !Service.currentApp` because of Bug 896322.
Updated patch.
Adding and fixing tests now.

Comment 29

[Evan Tseng [:evanxd]]

Comment on attachment 8598463 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29763

Hi Alive,

Could you help to review the patch?

Thanks.

Comment 30

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8598463 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29763

r=me, thx

Comment 31

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/efb8e902e467bf7aa640cfe70d6ad470d0a4ceea

Comment 32

[Shally Li（leave from Mozilla）]

Per Comment 31,this bug has been landed and fixed on master.


This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0 and Comment 17.

Actual results: Device enters suspend mode after reboot when "Screen timeout" is "Never".
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

-----------------------------------------------------------------------------
Device: Flame 3.0 build(Pass)
Build ID               20150505010204
Gaia Revision          70077825aab2c7a79611befb40a5fe7e610d5443
Gaia Date              2015-05-04 18:09:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150505.043622
Firmware Date          Tue May  5 04:36:34 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150505160203
Gaia Revision          42dc5f02a9df006b129824cd9bffa93cab937ab2
Gaia Date              2015-05-05 11:06:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5907a8eca521
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150505.192812
Firmware Date          Tue May  5 19:28:29 EDT 2015
Bootloader             HHZ12f

-------------------------------------------------------------
Add "verifyme" for v2.1&2.2 uplift & verification.

Comment 33

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 34

[Norry.L.F(Leave from Mozilla)]

Hi Evan,

Thanks for that the bug has been fixed on master, and could you confirm whether the patch will land on flame v2.1&flame v2.2 or not?  thanks a lot :)

Comment 35

[Evan Tseng [:evanxd]]

Hi Norry.L.F,

We need to land the below two commits at same time to fix bugs in v2.2.
1. https://github.com/evanxd/gaia/commit/34c67fd8ec8a0afff380655555a5f07fa1441de5
2. https://github.com/evanxd/gaia/commit/3687d7a4ce570cb3e2764d569d6b975e88bf2b44

No patch for v2.1 yet.

Comment 36

[Shally Li（leave from Mozilla）]

The master has verified, so clear 'verifyme' keywords.