1116139 - atrapalo.com overlay banner too big for screen on Firefox OS

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Hallvord R. M. Steen [:hallvors]]

Site: http://atrapalo.com
atrapalo.com overlay banner too big for screen on Firefox OS

:: Steps To Reproduce

Bug 888207 is still fixed, we get the nice responsive site - but there's some script or backend that still assumes Firefox OS smartphones have a desktop browser, and places a big banner encouraging you to become a member of the site or something like that on top of the nice and responsive content.

:: Expected Result

Site

:: Actual Result

Banner

:: Additional Information

Software Version: 2.0
Reporter's User Agent: Mozilla/5.0 (Mobile; rv:26.0) Gecko/26.0 Firefox/26.0

Comment 1

[Hallvord R. M. Steen [:hallvors]]

Attachment: This is what the screen looks like with the overlay banner

Comment 2

[Hallvord R. M. Steen [:hallvors]]

Here's some code from http://www.atrapalo.com/js_new/r141229135413/dist/modules/front/home/home.main.js


define("front/widgets/leadsAcquisitionPopUp/leadsAcquisitionPopupAsyncLoader",[],function(){return{start:function(){this.mustShowPopUp()&&this.show()},mustShowPopUp:function(){return!this.isSmartphone()&&!this.userHasDomainCookies()}

and

,isSmartphone:function(){return/iphone|ipad|ipod|android|blackberry|mini|windows\sce|palm/i.test(navigator.userAgent.toLowerCase())}

It would be better and simpler to just check if the screen is wide enough to accomodate the fixed-width banner. One might even choose to make the banner responsive too.

Comment 3

[Hallvord R. M. Steen [:hallvors]]

Mike, you did the outreach last time - can you handle this?

Comment 4

[Mike Taylor [:miketaylr]]

@Hallvord, my Spanish is so painfully rusty. ^_^ 
@Leonard, would you mind helping out with outreach on this? The analysis and suggested fix is in Comment #2.

Comment 5

[Leonard Camacho [:lcamacho]]

Bug filled in their google form.

Comment 6

[Mike Taylor [:miketaylr]]

Thanks!

Comment 7

[Hallvord R. M. Steen [:hallvors]]

Problem is gone - hope it remains fixed :)