Closed Bug 1116175 Opened 6 years ago Closed 6 years ago
Write a gaia UI test for moztrap test "Share a music as a ringtone - Use as default ringtone"
Write a moztrap test for: https://moztrap.mozilla.org/manage/case/14863/ Open Music app, and select a song to play The song is shown on screen with the two overlays on the image. The top overlay contains the share icon on the right side Tap the Share icon Another window opens allowing you to select from a number of options, including: E-mail, Ringtones, Messages and Bluetooth. Select the "Ringtones" button. Checked "Use as default ringtone" and Press "Save" button You should receive a notification ("Ringtone set as default") and the name of your selection flashes briefly in the notification area. Call the device several times from another phone. Confirm the track you select begins playing each time the phone rings. Inspect the Sound category in the Settings app. The ringtone you selected should show under the "Ringer" section.
Flags: in-qa-testsuite?(martijn.martijn) → in-qa-testsuite+
Resetting back to in-qa-testsuite? per decision this morning. Note that this is still not needed when adding the QA Whiteboard flags, which are generally more expressive.
Flags: in-qa-testsuite+ → in-qa-testsuite?
Assignee: nobody → martijn.martijn
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-backlog+][fxosqa-auto-s8]
QA Whiteboard: [fxosqa-auto-backlog+][fxosqa-auto-s8] → [fxosqa-auto-backlog+]
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s8]
I think this is ready for review. I see one intermittent failure, but that's bug 1126080. This hasn't the call part of the manual test implemented (will do that later in another bug). Also, the notification ("Ringtone set as default") is not working yet, but that should be fixed as part of the System app fix in bug 1074117.
Autolander will automatically attach patches for you from now, so please use the attachment next time that it generates it if possible. For more info see the announcement here: https://groups.google.com/forum/#!topic/mozilla.dev.gaia/cTevbcnUr38 Let me know if you have any problems or suggestions about how to improve the process. Thanks!
Comment on attachment 8558279 [details] [review] share_music_ringtone2 Looks good to me and it's consistently passing when running multiple times. Added a small comment, it is up to Martijn to implement it
Attachment #8558279 - Flags: review?(npark) → review+
Attachment #8558279 - Flags: review?(jlorenzo)
Comment on attachment 8558279 [details] [review] share_music_ringtone2 A wait and a comment to change in the code and I think this test is ready to be merged. Re-ask me for review so I'll merge the PR after.
Attachment #8558279 - Flags: review?(jlorenzo) → review-
Comment on attachment 8558279 [details] [review] share_music_ringtone2 Ok, filed bug 1130538 and added this as a reference in the comment. I had to add a player_view.wait_until_player_view_displayed method to make sure that the player view was visible, before I could remove that other code you mentioned I could remove.
Attachment #8558279 - Flags: review- → review?(jlorenzo)
Comment on attachment 8558279 [details] [review] share_music_ringtone2 Treeherder is green, the test runs correctly on my device and I don't see see any major issue in the code.
Attachment #8558279 - Flags: review?(jlorenzo) → review+
Merged in master at https://github.com/mozilla-b2g/gaia/commit/53d81870dc547fa57b915b06457142e4ee1051b2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Post-merge issue: Martijn and I noticed that the Moztrap link is not correct: https://github.com/mozilla-b2g/gaia/commit/53d81870dc547fa57b915b06457142e4ee1051b2#diff-b9d29c41f7e2635f9da36f164db3c91dR27 As it's a minor issue, it sounds better to fix it another but rather than backing this one out and merge it again. NI Martijn to include that in the next Music test.
I had to back this out, because it was orange on b2g desktop Mac (gaia-py-latest)mwargers:gaia_clean mwargers$ git revert -m 1 53d81870dc547fa57b915b06457142e4ee1051b2 [master 994896b] Revert "Merge pull request #27867 from mwargers/share_music_ringtone2" 6 files changed, 88 deletions(-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8561739 [details] [review] [PullReq] mwargers:share_music_ringtone2 to mozilla-b2g:master I'm going back to the method that No-Jun used too in test_music_change_rating.py That seems to work reliably across all platforms.
Attachment #8561739 - Flags: review?(jlorenzo)
No failures on b2g desktop and device after 10 retries.
Comment on attachment 8561739 [details] [review] [PullReq] mwargers:share_music_ringtone2 to mozilla-b2g:master This still looks a bit hack-ish to me. But as we're freezing the Marionette Python suite, I would prefer a test which is more stable than perfectly written. Let's keep the current wait then.
Attachment #8561739 - Flags: review?(jlorenzo) → review+
Merge in master at: https://github.com/mozilla-b2g/gaia/commit/184c4fa44f829bf769a04f5c44e0a1244ee32ece
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #16) > Comment on attachment 8561739 [details] [review] > [PullReq] mwargers:share_music_ringtone2 to mozilla-b2g:master > > This still looks a bit hack-ish to me. But as we're freezing the Marionette > Python suite, I would prefer a test which is more stable than perfectly > written. > > Let's keep the current wait then. I agree, it looks a bit weird, and I don't understand exactly why I need and couldn't use a more suitable method. Perhaps No-Jun would know.
Actually, what was the method that I used in in test_music_change_rating.py again? I was also using the examples from other music scripts, because I wasn't so familiar with the music app.
Never mind then. Current method works and trying to get the correct way of doing things here would take quite some time, which is not worth the effort, imho.
You need to log in before you can comment on or make changes to this bug.