1116234 - test_bug437844.xul fails when run as a standalone directory

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Vaibhav (:vaibhav1994)]

in bug 1110982, we are looking to enable tests where we run a fresh browser instance per directory.  Usually what happens is that a few tests fail because they accidentally depend on the state of the browser from an earlier test.

In the try run, on osx 10.6 debug, the following error can be seen:

 2632 INFO TEST-UNEXPECTED-OK | toolkit/content/tests/chrome/test_bug437844.xul | Assertion count 18 is less than expected range 19-22 assertions. 

This patch solves it: https://hg.mozilla.org/try/diff/0070a30de170/toolkit/content/tests/chrome/test_bug437844.xul

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Ryan, what is the procedure for expanding the scope of assertions?  It seems as though there is no real review process based on historical changing of the expected assertions:
http://hg.mozilla.org/mozilla-central/filelog/44344099d119/toolkit/content/tests/chrome/test_bug437844.xul

Comment 2

[Ryan VanderMeulen [:RyanVM]]

"The test is perma-failing and we don't want it to - r+"

But seriously, the asserts aren't changing (i.e. something new breaking), only the number varying slightly for whatever reason. Just make it 18-22 and let's get on with our lives.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: change the assertions to include 18 (1.0)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8542554 [details] [diff] [review]
change the assertions to include 18 (1.0)

Review of attachment 8542554 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88af20920b2b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88af20920b2b