tracking bug to get --run-by-dir enabled for 'oth' job on trunk

RESOLVED FIXED in Firefox 38

Status

Testing
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: vaibhav1994, Assigned: jmaher)

Tracking

(Depends on: 17 bugs, {leave-open})

unspecified
mozilla38
leave-open
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(3 attachments, 6 obsolete attachments)

Comment hidden (empty)
(Reporter)

Comment 1

3 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=054c7cc31858 - Try push in which some tests are disabled that were failing with run-by-dir previously.
(Reporter)

Comment 2

3 years ago
Try push with more tests disabled to tackle leakchecks: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=59952fa0bb96
(Assignee)

Updated

3 years ago
Depends on: 1115063
(Assignee)

Updated

3 years ago
Depends on: 1115076
(Reporter)

Updated

3 years ago
Depends on: 1115088
(Reporter)

Updated

3 years ago
Depends on: 1115084
(Reporter)

Updated

3 years ago
Depends on: 1115092
(Assignee)

Comment 3

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=547c73267a01
(Assignee)

Comment 4

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=3807db5aea2f
(Reporter)

Updated

3 years ago
Depends on: 1116195
(Reporter)

Updated

3 years ago
Depends on: 1116202
(Reporter)

Updated

3 years ago
Depends on: 1116205
(Assignee)

Updated

3 years ago
No longer depends on: 1116202
(Assignee)

Updated

3 years ago
Depends on: 1116202
(Reporter)

Updated

3 years ago
Depends on: 1114710
(Reporter)

Updated

3 years ago
Depends on: 1116215
(Assignee)

Updated

3 years ago
Depends on: 1116230
(Reporter)

Updated

3 years ago
Depends on: 1116234
(Reporter)

Comment 5

3 years ago
Created attachment 8542259 [details] [diff] [review]
oth-disabled_tests.patch

The list of disabled tests for complete green push for oth jobs on try.

The green push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=506a7fcead24
(Assignee)

Updated

3 years ago
Depends on: 1116763

Updated

3 years ago
Depends on: 1117727
(Assignee)

Comment 6

3 years ago
this try push shows that no new issues have cropped up:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14a8a8c29665

14 tests were disabled in that one, pushing a few more times to see if the other failures are still there
(Assignee)

Updated

3 years ago
Depends on: 1125958
(Assignee)

Updated

3 years ago
Depends on: 1130751
(Assignee)

Comment 7

3 years ago
Created attachment 8561375 [details] [diff] [review]
disable 5 tests for mochitest-chrome, enable run-by-dir for m-oth jobs (1.0)

silence on needinfo? requests for a week yields disabling!  The ASAN leak is ok'd to disable.
Assignee: nobody → jmaher
Attachment #8542259 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8561375 - Flags: review?(ryanvm)
Attachment #8561375 - Flags: review?(ryanvm) → review+
(Assignee)

Comment 8

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a53c8b6ab6df
(Assignee)

Updated

3 years ago
Depends on: 1131110
Depends on: 1131116
Depends on: 1131218
https://hg.mozilla.org/mozilla-central/rev/a53c8b6ab6df
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1131290
Depends on: 1131291
Depends on: 1131293
(Assignee)

Comment 10

3 years ago
Created attachment 8562080 [details] [diff] [review]
turn_off_runbydir.patch
Attachment #8562080 - Flags: review?(ryanvm)
Comment on attachment 8562080 [details] [diff] [review]
turn_off_runbydir.patch

Thanks Joel, was worth a shot :(
Attachment #8562080 - Flags: review?(ryanvm) → review+
(Assignee)

Updated

3 years ago
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
(Assignee)

Comment 12

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8aff9d15d3
Depends on: 1131720
Depends on: 1131725
https://hg.mozilla.org/mozilla-central/rev/bf8aff9d15d3
Depends on: 1134334
(Assignee)

Updated

3 years ago
Depends on: 1136395
(Assignee)

Updated

3 years ago
Depends on: 1144334
(Assignee)

Updated

3 years ago
Depends on: 1156725
(Assignee)

Updated

3 years ago
Depends on: 1156956
(Assignee)

Updated

3 years ago
Depends on: 1161840
(Assignee)

Updated

2 years ago
Depends on: 1170192
Depends on: 1207156
Depends on: 1207161
Depends on: 1202548
Depends on: 1207174
Depends on: 1207190
Depends on: 1167694
Created attachment 8664379 [details] [diff] [review]
rbd_chrome.patch
(Assignee)

Comment 15

2 years ago
Comment on attachment 8664379 [details] [diff] [review]
rbd_chrome.patch

Review of attachment 8664379 [details] [diff] [review]:
-----------------------------------------------------------------

this look great, thanks for the clean bugs and hard work on tracking this down.
Attachment #8664379 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Note this patch as written will conflict with bug 912121, all DevTools files have moved, and same test manifest lines were also modified.
(Assignee)

Comment 17

2 years ago
thanks jryans, :kaustabh, can you 'hg pull -u' and refresh your patch?  I have removed the checkin-needed until we refresh.
Keywords: checkin-needed
Created attachment 8664961 [details] [diff] [review]
rbd_chrome.patch
Attachment #8664379 - Attachment is obsolete: true
Created attachment 8664997 [details] [diff] [review]
rbd_chrome.patch
Attachment #8664961 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8664997 - Flags: review+
Depends on: 1131634
(Assignee)

Comment 20

2 years ago
this had the wrong bug number in the comment, but it landed last week:
https://hg.mozilla.org/mozilla-central/rev/81fca7e4e6ef
Depends on: 1176038
Depends on: 1210863
Depends on: 1210876
Created attachment 8669120 [details] [diff] [review]
rbd_chrome.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d8f8827d83
Created attachment 8669122 [details] [diff] [review]
rbd_chrome.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91d8f8827d83
Attachment #8664997 - Attachment is obsolete: true
Attachment #8669120 - Attachment is obsolete: true
Created attachment 8669342 [details] [diff] [review]
rbd_chrome.patch
Attachment #8669122 - Attachment is obsolete: true
(Assignee)

Comment 24

2 years ago
Comment on attachment 8669342 [details] [diff] [review]
rbd_chrome.patch

Review of attachment 8669342 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great!
Attachment #8669342 - Flags: review+
(Assignee)

Comment 25

2 years ago
ok, this will get us running in run-by-dir for the oth job on debug- we will see a hit on runtime, Ideally we could now chunk chrome to reduce our overall runtime.  the problem is we have a11y in the other job as well as chrome, if we want to chunk chrome we need to change oth to just be a11y, then run chrome in X chunks.

There could be other realistic ways to solve this, I am open to all ideas.
Flags: needinfo?(jgriffin)
Yeah I'm thinking we get rid of mochitest-oth and replace it with separate jobs for chrome and a11y.  This makes a lot of downstream stuff easier as well, if we don't have to worry about different suites being run in the same job.  That's an old optimization that probably doesn't make sense any longer.
Flags: needinfo?(jgriffin)
(Assignee)

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.