Closed Bug 1110982 Opened 5 years ago Closed 4 years ago

tracking bug to get --run-by-dir enabled for 'oth' job on trunk

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: vaibhav1994, Assigned: jmaher)

References

(Depends on 11 open bugs)

Details

Attachments

(3 files, 6 obsolete files)

No description provided.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=054c7cc31858 - Try push in which some tests are disabled that were failing with run-by-dir previously.
Try push with more tests disabled to tackle leakchecks: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=59952fa0bb96
Depends on: 1115063
Depends on: 1115076
Depends on: 1115088
Depends on: 1115084
Depends on: 1115092
Depends on: 1116195
Depends on: 1116202
Depends on: 1116205
No longer depends on: 1116202
Depends on: 1116202
Depends on: 1114710
Depends on: 1116215
Depends on: 1116230
Depends on: 1116234
Attached patch oth-disabled_tests.patch (obsolete) — Splinter Review
The list of disabled tests for complete green push for oth jobs on try.

The green push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=506a7fcead24
Depends on: 1116763
Depends on: 1117727
this try push shows that no new issues have cropped up:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14a8a8c29665

14 tests were disabled in that one, pushing a few more times to see if the other failures are still there
Depends on: 1125958
Depends on: 1130751
silence on needinfo? requests for a week yields disabling!  The ASAN leak is ok'd to disable.
Assignee: nobody → jmaher
Attachment #8542259 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8561375 - Flags: review?(ryanvm)
Attachment #8561375 - Flags: review?(ryanvm) → review+
Depends on: 1131110
Depends on: 1131116
Depends on: 1131218
https://hg.mozilla.org/mozilla-central/rev/a53c8b6ab6df
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1131290
Depends on: 1131291
Depends on: 1131293
Attachment #8562080 - Flags: review?(ryanvm)
Comment on attachment 8562080 [details] [diff] [review]
turn_off_runbydir.patch

Thanks Joel, was worth a shot :(
Attachment #8562080 - Flags: review?(ryanvm) → review+
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Depends on: 1131720
Depends on: 1131725
Depends on: 1136395
Depends on: 1144334
Depends on: 1156725
Depends on: 1156956
Depends on: 1161840
Depends on: 1170192
Depends on: 1207156
Depends on: 1207161
Depends on: 1202548
Depends on: 1207174
Depends on: 1207190
Depends on: 1167694
Attached patch rbd_chrome.patch (obsolete) — Splinter Review
Comment on attachment 8664379 [details] [diff] [review]
rbd_chrome.patch

Review of attachment 8664379 [details] [diff] [review]:
-----------------------------------------------------------------

this look great, thanks for the clean bugs and hard work on tracking this down.
Attachment #8664379 - Flags: review+
Keywords: checkin-needed
Note this patch as written will conflict with bug 912121, all DevTools files have moved, and same test manifest lines were also modified.
thanks jryans, :kaustabh, can you 'hg pull -u' and refresh your patch?  I have removed the checkin-needed until we refresh.
Keywords: checkin-needed
Attached patch rbd_chrome.patch (obsolete) — Splinter Review
Attachment #8664379 - Attachment is obsolete: true
Attached patch rbd_chrome.patch (obsolete) — Splinter Review
Attachment #8664961 - Attachment is obsolete: true
Attachment #8664997 - Flags: review+
Depends on: 1131634
this had the wrong bug number in the comment, but it landed last week:
https://hg.mozilla.org/mozilla-central/rev/81fca7e4e6ef
Depends on: 1176038
Depends on: 1210863
Depends on: 1210876
Attached patch rbd_chrome.patchSplinter Review
Attachment #8669122 - Attachment is obsolete: true
Comment on attachment 8669342 [details] [diff] [review]
rbd_chrome.patch

Review of attachment 8669342 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great!
Attachment #8669342 - Flags: review+
ok, this will get us running in run-by-dir for the oth job on debug- we will see a hit on runtime, Ideally we could now chunk chrome to reduce our overall runtime.  the problem is we have a11y in the other job as well as chrome, if we want to chunk chrome we need to change oth to just be a11y, then run chrome in X chunks.

There could be other realistic ways to solve this, I am open to all ideas.
Flags: needinfo?(jgriffin)
Yeah I'm thinking we get rid of mochitest-oth and replace it with separate jobs for chrome and a11y.  This makes a lot of downstream stuff easier as well, if we don't have to worry about different suites being run in the same job.  That's an old optimization that probably doesn't make sense any longer.
Flags: needinfo?(jgriffin)
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.