1116304 - context menu too big / nonnative for in-content prefs password manager

Status: RESOLVED DUPLICATE of bug 1247214

(Firefox :: Settings UI, defect, P4)

Description

[Justin Dolske [:Dolske]]

Attachment: Too big

See screenshot. The in-content prefs has a content menu that's way too big and non-native. It's ok in other places, so far I've only noticed it in the password manager.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Normal

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Reproducible on Windows too

Comment 3

[:Gijs (he/him)]

I think this should block shipping, if only because there are a number of these size bugs which should be fixable in one fell swoop, and together they should block shipping. :-)

Comment 4

[Ian Moody [:Kwan] (UTC+1)]

This will be true of any context menu in a dialog (here, popup exceptions, cookie exceptions, show cookies, addon install exceptions).

https://dxr.mozilla.org/mozilla-central/source/browser/themes/osx/preferences/in-content/dialog.css#12
https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/preferences/in-content/dialog.css#7
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/preferences/in-content/dialog.css#7

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Ian Moody (:Kwan) from comment #4)

Thanks for finding that. Would you be interested in putting together a patch to fix this?

Comment 6

[Ian Moody [:Kwan] (UTC+1)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> (In reply to Ian Moody (:Kwan) from comment #4)
> 
> Thanks for finding that. Would you be interested in putting together a patch
> to fix this?

Yeah I'd be willing to do so.
Not sure what the best approach would be though.  There's no obvious :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could :not().

Comment 7

[:Gijs (he/him)]

(In reply to Ian Moody (:Kwan) from comment #6)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> > (In reply to Ian Moody (:Kwan) from comment #4)
> > 
> > Thanks for finding that. Would you be interested in putting together a patch
> > to fix this?
> 
> Yeah I'd be willing to do so.
> Not sure what the best approach would be though.  There's no obvious
> :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could
> :not().

Does switching these rules to rem instead of em work? (Might not, but worth a shot)

Comment 8

[Ian Moody [:Kwan] (UTC+1)]

(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Ian Moody (:Kwan) from comment #6)
> > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> > > (In reply to Ian Moody (:Kwan) from comment #4)
> > > 
> > > Thanks for finding that. Would you be interested in putting together a patch
> > > to fix this?
> > 
> > Yeah I'd be willing to do so.
> > Not sure what the best approach would be though.  There's no obvious
> > :-moz-anonymous-content/:-moz-xbl-generated I can see on MDN that I could
> > :not().
> 
> Does switching these rules to rem instead of em work? (Might not, but worth
> a shot)

It does not.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

De-listing from the hard-blocker list as this is a pretty small corner case and doesn't prohibit usage.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

This should have been fixed by bug 1247214. Katie, can you confirm?

Comment 12

[Katie Broida [:ktbee]]

Confirmed! We resolved this font issue in bug 1247214 by preventing the context menu from inheriting the dialog box's styling.