Closed Bug 1116355 Opened 5 years ago Closed 5 years ago

Throw when setting SourceBuffer mode to 'sequence'

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Attachment #8542368 - Flags: review?(cajbir.bugzilla)
Comment on attachment 8542368 [details] [diff] [review]
Throw when setting SourceBuffer mode to 'sequence'. v1

I would use NOT_SUPPORTED_ERR for a public API like this.
Attachment #8542368 - Flags: review?(cajbir.bugzilla) → review+
(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #2)
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9e2c2c29ba40

Green.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1f3c8d40cdf
sorry had to backout this change for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=4996214&repo=mozilla-inbound
Flags: needinfo?(bobbyholley)
https://hg.mozilla.org/mozilla-central/rev/d227893d3204
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8542368 [details] [diff] [review]
Throw when setting SourceBuffer mode to 'sequence'. v1

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low, this is MSE-specific code.
[String/UUID change made/needed]: None.
Attachment #8542368 - Flags: approval-mozilla-aurora?
Attachment #8542368 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.