Closed
Bug 1116384
Opened 9 years ago
Closed 9 years ago
attached MediaSources should keep their media element alive
Categories
(Core :: Audio/Video, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: karlt, Assigned: karlt)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.05 KB,
patch
|
roc
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
SourceBuffer.appendBuffer() can require its MediaSource's attached media element to queue progress and/or durationchange events, and so the media element needs to live long enough to do this. Similarly MediaSource.endOfStream() can generate suspend and/or durationchange events. This is currently not a direct problem due to bug 1114885 and the media element always NETWORK_LOADING even though it should be NETWORK_IDLE after MediaSource.endOfStream() is called (at least) if no frames have been evicted.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8542414 -
Flags: review?(roc)
Attachment #8542414 -
Flags: review?(roc) → review+
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef5666f6f49e
Flags: in-testsuite-
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ef5666f6f49e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 4•9 years ago
|
||
Comment on attachment 8542414 [details] [diff] [review] keep media element alive from attached MediaSource r? Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve Flash video. [Describe test coverage new/current, TBPL]: landed on m-c. [Risks and why]: Low. This does affect non-MSE code, but it straightforward. [String/UUID change made/needed]: None.
Attachment #8542414 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8542414 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•