attached MediaSources should keep their media element alive

RESOLVED FIXED in Firefox 36

Status

()

Core
Audio/Video
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla37
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
SourceBuffer.appendBuffer() can require its MediaSource's attached media
element to queue progress and/or durationchange events, and so the
media element needs to live long enough to do this.  Similarly MediaSource.endOfStream() can generate suspend and/or durationchange events.

This is currently not a direct problem due to bug 1114885 and the media element always NETWORK_LOADING even though it should be NETWORK_IDLE after
MediaSource.endOfStream() is called (at least) if no frames have been evicted.
(Assignee)

Updated

4 years ago
Blocks: 778617
(Assignee)

Comment 1

4 years ago
Created attachment 8542414 [details] [diff] [review]
keep media element alive from attached MediaSource r?
Attachment #8542414 - Flags: review?(roc)
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/ef5666f6f49e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8542414 [details] [diff] [review]
keep media element alive from attached MediaSource r?

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This does affect non-MSE code, but it straightforward.
[String/UUID change made/needed]: None.
Attachment #8542414 - Flags: approval-mozilla-aurora?
status-firefox36: --- → affected
status-firefox37: --- → fixed
Attachment #8542414 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.