1114885 - Unreferenced media elements with MediaSources can leak due to NETWORK_LOADING

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Karl Tomlinson (:karlt)]

Media elements keep a self reference when networkState is NETWORK_LOADING.
Usually a load request would eventually time out, networkState would change, and the self reference would be removed, but this will not happen when the source is a MediaSource.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: webm/vorbis audio file for testcase

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: testcase (with explicit URL revocation)

1. Set media.mediasource.enabled and media.mediasource.webm.enabled prefs to
   true, if not already.

2. Load testcase.

3. Observe memory use growing (in top or similar).

4. Load about:memory in another tab.

5. Click "Minimize Memory Use".

Expected: Memory usage reduces somewhat, before growing again.

Actual: Memory use continues to rise.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: allow media elements to be GC'd when their MediaSource is unreferenced r?

Comment 4

[Karl Tomlinson (:karlt)]

https://tbpl.mozilla.org/?tree=Try&rev=a17b39048bc5
https://tbpl.mozilla.org/?tree=Try&rev=caedea5cc2a3

Comment 5

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f1bd578a2a6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f1bd578a2a6

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8542415 [details] [diff] [review]
allow media elements to be GC'd when their MediaSource is unreferenced r?

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, YouTube videos consume more resources.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This is a small change and should only affect MSE playback.
[String/UUID change made/needed]: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/44e174f9d843

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Verified using STR from comment 2 and the attached testcases and got the expected results using:
1. Firefox 36 beta 2, build ID: 20150120155007
2. Latest Aurora, build ID: 20150121004011

Tested on Ubuntu 12.04 64-bit.