Closed Bug 1116523 Opened 6 years ago Closed 6 years ago
add new response id to session
The Thank You page project requires that the "thanks" view is passed details about the user's feedback so that it can determine which variation of the Thank You page to show and can do whatever work it needs to do to do so. This bug covers changing the feedback post code so that if a response is successfully saved to the db, the response id is saved in the user's session before the redirect to the Thank You page. The feedback post code is in fjord/feedback/views.py in _handle_feedback_post. The place to add the response id to the session is towards the bottom of that function. At that point, the response has been saved. We'll save the response id for all users and let the thank you view deal with figuring out which users get to see which variation of the thank you page. Helpful docs: https://docs.djangoproject.com/en/1.6/topics/http/sessions/#using-sessions-in-views https://docs.djangoproject.com/en/1.6/topics/http/sessions/#examples
Assigning this to Adam.
Assignee: nobody → aokoye
Status: NEW → ASSIGNED
Landed in https://github.com/mozilla/fjord/commit/28ad32872704aa0ddc85fef7e08f36926fc920e1 I'll push this out Monday or after release week.
This got pushed out on Friday. Marking as FIXED! Thank you!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Moving things out of the input.adam sprint.
Whiteboard: u=user c=feedback p= s=input.adam → u=user c=feedback p= s=input.2015q1
You need to log in before you can comment on or make changes to this bug.