TestUrgentHangs.cpp doesn't compile on windows

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Tracking

unspecified
mozilla37
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch Patch, v1Splinter Review
This needs a windows-compatible sleep function.
Attachment #8542761 - Flags: review?(wmccloskey)
Comment on attachment 8542761 [details] [diff] [review]
Patch, v1

Review of attachment 8542761 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. Any chance you're trying to get these running in production? I sorta remembered you use MacOS.
Attachment #8542761 - Flags: review?(wmccloskey) → review+
I don't think we can do much to get these running in production, they make a ton of useless protocols, bloat libxul, and will never be exercised outside of the unit tests. We could have a separate build configuration for them on test infra but we'd also be adding a ton of build time...

I use Windows on my MacBook Pro.
https://hg.mozilla.org/mozilla-central/rev/4ed5726c356b
Assignee: nobody → bent.mozilla
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.