1116640 - TestUrgentHangs.cpp doesn't compile on windows

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This needs a windows-compatible sleep function.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8542761 [details] [diff] [review]
Patch, v1

Review of attachment 8542761 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. Any chance you're trying to get these running in production? I sorta remembered you use MacOS.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I don't think we can do much to get these running in production, they make a ton of useless protocols, bloat libxul, and will never be exercised outside of the unit tests. We could have a separate build configuration for them on test infra but we'd also be adding a ton of build time...

I use Windows on my MacBook Pro.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed5726c356b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ed5726c356b