1116676 - Potential missing AddRemoveSelfReference in NoSupportedMediaSourceError().

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Karl Tomlinson (:karlt)]

Bug 975782 comment 17 wasn't quite right, because now that mDelayingLoadEvent
may already be false when NoSupportedMediaSourceError() is called,
ChangeDelayLoadStatus(false) won't necessarily call AddRemoveSelfReference().

Comment 1

[Karl Tomlinson (:karlt)]

https://tbpl.mozilla.org/?tree=Try&rev=2fd24f7059eb
https://tbpl.mozilla.org/?tree=Try&rev=249e5dc016a4

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: ensure that AddRemoveSelfReference() is called on networkState changes

Now that mDelayingLoadEvent may already be false when
NoSupportedMediaSourceError() is called, ChangeDelayLoadStatus(false) won't
necessarily call AddRemoveSelfReference().

Comment 3

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b242744ee147

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b242744ee147

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8543688 [details] [diff] [review]
ensure that AddRemoveSelfReference() is called on networkState changes

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, video playback stalls more likely with YouTube.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This does affect non-MSE video playback, but is a clean change and easy to revert.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad2cfe2a92a5