Potential missing AddRemoveSelfReference in NoSupportedMediaSourceError().

RESOLVED FIXED in Firefox 36

Status

()

P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla37
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 975782 comment 17 wasn't quite right, because now that mDelayingLoadEvent
may already be false when NoSupportedMediaSourceError() is called,
ChangeDelayLoadStatus(false) won't necessarily call AddRemoveSelfReference().
(Assignee)

Comment 2

4 years ago
Created attachment 8543688 [details] [diff] [review]
ensure that AddRemoveSelfReference() is called on networkState changes

Now that mDelayingLoadEvent may already be false when
NoSupportedMediaSourceError() is called, ChangeDelayLoadStatus(false) won't
necessarily call AddRemoveSelfReference().
Attachment #8543688 - Flags: review?(roc)
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/b242744ee147
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8543688 [details] [diff] [review]
ensure that AddRemoveSelfReference() is called on networkState changes

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, video playback stalls more likely with YouTube.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This does affect non-MSE video playback, but is a clean change and easy to revert.
[String/UUID change made/needed]: None.
Attachment #8543688 - Flags: approval-mozilla-beta?
status-firefox36: --- → affected
status-firefox37: --- → fixed
Attachment #8543688 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.