Closed
Bug 1116676
Opened 9 years ago
Closed 9 years ago
Potential missing AddRemoveSelfReference in NoSupportedMediaSourceError().
Categories
(Core :: Audio/Video, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
6.31 KB,
patch
|
roc
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 975782 comment 17 wasn't quite right, because now that mDelayingLoadEvent may already be false when NoSupportedMediaSourceError() is called, ChangeDelayLoadStatus(false) won't necessarily call AddRemoveSelfReference().
Assignee | ||
Comment 1•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2fd24f7059eb https://tbpl.mozilla.org/?tree=Try&rev=249e5dc016a4
Assignee | ||
Comment 2•9 years ago
|
||
Now that mDelayingLoadEvent may already be false when NoSupportedMediaSourceError() is called, ChangeDelayLoadStatus(false) won't necessarily call AddRemoveSelfReference().
Attachment #8543688 -
Flags: review?(roc)
Attachment #8543688 -
Flags: review?(roc) → review+
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b242744ee147
Flags: in-testsuite-
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b242744ee147
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 5•9 years ago
|
||
Comment on attachment 8543688 [details] [diff] [review] ensure that AddRemoveSelfReference() is called on networkState changes Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, video playback stalls more likely with YouTube. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Low. This does affect non-MSE video playback, but is a clean change and easy to revert. [String/UUID change made/needed]: None.
Attachment #8543688 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8543688 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•