Closed Bug 1116676 Opened 6 years ago Closed 6 years ago

Potential missing AddRemoveSelfReference in NoSupportedMediaSourceError().

Categories

(Core :: Audio/Video, defect, P2)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

Bug 975782 comment 17 wasn't quite right, because now that mDelayingLoadEvent
may already be false when NoSupportedMediaSourceError() is called,
ChangeDelayLoadStatus(false) won't necessarily call AddRemoveSelfReference().
Now that mDelayingLoadEvent may already be false when
NoSupportedMediaSourceError() is called, ChangeDelayLoadStatus(false) won't
necessarily call AddRemoveSelfReference().
Attachment #8543688 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/b242744ee147
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8543688 [details] [diff] [review]
ensure that AddRemoveSelfReference() is called on networkState changes

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, video playback stalls more likely with YouTube.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This does affect non-MSE video playback, but is a clean change and easy to revert.
[String/UUID change made/needed]: None.
Attachment #8543688 - Flags: approval-mozilla-beta?
Attachment #8543688 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.