Closed
Bug 1116838
Opened 10 years ago
Closed 10 years ago
add waffle flag for thank you page
Categories
(Input Graveyard :: Submission, defect)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: aokoye)
References
Details
(Whiteboard: u=user c=feedback p= s=input.2015q1)
The Thank You page project will require a waffle flag so that we can implement and test it before anyone else sees it.
To create the flag, we'll need to:
1. figure out a name for it
2. create a data migration for the feedback app
This bug covers creating that waffle flag.
Reporter | ||
Comment 1•10 years ago
|
||
Documentation for django-waffle is here: http://waffle.readthedocs.org/en/latest/
In particular, we're going to create a Flag: http://waffle.readthedocs.org/en/latest/types.html#flags
We're going to create it using a data migration. Doing a data migration allows us to make sure all Fjord environments (dev environments, -dev servers, -stage servers and -prod servers) get the flag just by running:
./manage.py migrate
That makes it pretty convenient.
Here's an example data migration that creates a flag:
https://github.com/mozilla/fjord/blob/945eab73d558b2c0a39a880068d33cf30730a110/fjord/base/migrations/0004_create_chart_flag.py
Most of that is auto-generated using the datamigratation command:
./manage.py datamigration
There's documentation I just wrote that covers making data migrations for things like waffle flags.
http://fjord.readthedocs.org/en/latest/db.html#creating-a-data-migration
Reporter | ||
Comment 3•10 years ago
|
||
Assigning this to Adam who did the work.
Landed in https://github.com/mozilla/fjord/commit/99217594250ba7a7e853609cb3bb27d293bd673f
Waiting until Monday to deploy and resolve.
Assignee: nobody → aokoye
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•10 years ago
|
||
Pushed to production just now. Verified the flag exists. Marking as FIXED.
Thank you!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•10 years ago
|
||
Moving things out of the input.adam sprint.
Whiteboard: u=user c=feedback p= s=input.adam → u=user c=feedback p= s=input.2015q1
Updated•8 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•